compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java - Issue 8913016: Issue 839: Bad code leading to top level methods being something other than identifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java

Issue 8913016: Issue 839: Bad code leading to top level methods being something other than identifier (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Nits Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java b/compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java

index 4020880a6306790851290c072778e5159cee71c7..238fc67bf11b4a63be624be7004150a1ccba1646 100644

--- a/compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java

+++ b/compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java

@@ -133,8 +133,13 @@ class MethodElementImplementation extends AbstractElement implements MethodEleme

public static MethodElementImplementation fromMethodNode(DartMethodDefinition node,

EnclosingElement holder) {

- assert node.getName() instanceof DartIdentifier;

- String targetName = ((DartIdentifier) node.getName()).getTargetName();

+ String targetName;

+ if(node.getName() instanceof DartIdentifier) {

+ targetName = ((DartIdentifier) node.getName()).getTargetName();

+ } else {

+ // Visit the unknown node to generate a string for our use.

+ targetName = node.toSource();

+ }

return new MethodElementImplementation(node, targetName, holder);

}