[Password manager tests] Enable "Offer to save password" via webriver.

[Password manager tests] Enable "Offer to save password" via webriver.

Now tests are failing because "Offer to save passwords checkbox is
disabled". This patch enables it by running js script using webdriver.

R=vabr@chromium.org
BUG=435249
Committed: https://crrev.com/a5ab40a22b7002b0a836980f3f28d8a32a2b9b52
Cr-Commit-Position: refs/heads/master@{#314130}

[melandory, 2015-02-02 09:14:21]

Hi Vaclav,

review this CL, please.

[vabr (Chromium), 2015-02-02 09:25:29]

Thanks Tanjs!
LGTM with nits.
Cheers,
Vaclav

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
File components/test/data/password_manager/automated_tests/environment.py
(right):

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:192: #
Every time we do something we cache let's enable password saving.
possible typo:
we cache -> to the cache
?

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:193: #
TODO(melandory): We should check why it's off on a first place.
nit: on the first place -> in the first place
Also, could you please mention the role of chromedriver? For example:
"While saving passwords is enabled by default normally, once Chrome is run via
chromedriver, the setting is off."

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:195: #
often
nit: Missing a full stop at the end of the sentence.

[melandory, 2015-02-02 09:35:53]

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
File components/test/data/password_manager/automated_tests/environment.py
(right):

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:192: #
Every time we do something we cache let's enable password saving.
On 2015/02/02 09:25:29, vabr (Chromium) wrote:
> possible typo:
> we cache -> to the cache
> ?

Done.

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:193: #
TODO(melandory): We should check why it's off on a first place.
On 2015/02/02 09:25:29, vabr (Chromium) wrote:
> nit: on the first place -> in the first place
> Also, could you please mention the role of chromedriver? For example:
> "While saving passwords is enabled by default normally, once Chrome is run via
> chromedriver, the setting is off."

Done.

https://codereview.chromium.org/891283002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/environment.py:195: #
often
On 2015/02/02 09:25:29, vabr (Chromium) wrote:
> nit: Missing a full stop at the end of the sentence.

Done.

[melandory, 2015-02-02 09:36:11]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-02-02 09:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891283002/20001

[melandory, 2015-02-02 09:38:49]

The CQ bit was unchecked by melandory@chromium.org

[melandory, 2015-02-02 10:16:14]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-02-02 10:16:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891283002/20001

[melandory, 2015-02-02 10:17:31]

The CQ bit was unchecked by melandory@chromium.org

[melandory, 2015-02-02 11:35:23]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-02-02 11:36:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891283002/40001

[commit-bot: I haz the power, 2015-02-02 12:34:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-02 12:35:15]

Patchset 3 (id:??) landed as
https://crrev.com/a5ab40a22b7002b0a836980f3f28d8a32a2b9b52
Cr-Commit-Position: refs/heads/master@{#314130}