Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 891273003: components: Cleanup and sort the remaining deps lists. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Cleanup and sort the remaining deps lists. This removes the latest comments of "Dependencies of" and sort up these dependencies lists, so it will be easier for people coming up later and adding new entries, they will know exactly where to put them and it will be much easier to review them as well. BUG=None TEST=components_unittests, components_browsertests R=blundell@chromium.org Committed: https://crrev.com/562d5c5ae2db82622a707be5f2e348cc819289a6 Cr-Commit-Position: refs/heads/master@{#314782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M components/components_tests.gyp View 4 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 10 months ago (2015-02-04 21:13:49 UTC) #1
blundell
lgtm
5 years, 10 months ago (2015-02-05 09:35:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891273003/1
5 years, 10 months ago (2015-02-05 09:35:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 09:39:17 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 09:40:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/562d5c5ae2db82622a707be5f2e348cc819289a6
Cr-Commit-Position: refs/heads/master@{#314782}

Powered by Google App Engine
This is Rietveld 408576698