Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 891263003: Keep SVGImage alive across its animation timer callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: a stack protection is required here Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 m_animationTimer.startOneShot(fireTime, FROM_HERE); 79 m_animationTimer.startOneShot(fireTime, FROM_HERE);
80 } 80 }
81 81
82 void SVGImageChromeClient::animationTimerFired(Timer<SVGImageChromeClient>*) 82 void SVGImageChromeClient::animationTimerFired(Timer<SVGImageChromeClient>*)
83 { 83 {
84 if (!m_image) 84 if (!m_image)
85 return; 85 return;
86 // serviceScriptedAnimations runs requestAnimationFrame callbacks, but SVG 86 // serviceScriptedAnimations runs requestAnimationFrame callbacks, but SVG
87 // images can't have any so we assert there's no script. 87 // images can't have any so we assert there's no script.
88 ScriptForbiddenScope forbidScript; 88 ScriptForbiddenScope forbidScript;
89
90 // As neither SVGImage nor this chrome client object are on the Oilpan heap,
91 // this object's reference to the SVGImage will not be traced should a GC
92 // strike below. Hence, we must ensure that they both remain alive for
93 // duration of this call.
94 //
95 // This is cannot arise non-Oilpan as an ImageResource is an owned object
96 // and will be promptly released along with its (SVG)Image..and everything
97 // below, including this object and its timer. For code simplicity, the
98 // object protection isn't made the conditional on Oilpan.
99 //
100 // FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap
101 // to render this protection redundant.
102 RefPtr<SVGImage> protect(m_image);
89 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime()); 103 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime());
90 m_image->frameView()->updateLayoutAndStyleForPainting(); 104 m_image->frameView()->updateLayoutAndStyleForPainting();
91 } 105 }
92 106
93 } 107 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698