Source/web/tests/AssociatedURLLoaderTest.cpp - Issue 891263002: Prevent calling didReceiveData()/didFinishLoading() after didFailAccessControlCheck()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/AssociatedURLLoaderTest.cpp

Issue 891263002: Prevent calling didReceiveData()/didFinishLoading() after didFailAccessControlCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comment fix. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/AssociatedURLLoaderTest.cpp

diff --git a/Source/web/tests/AssociatedURLLoaderTest.cpp b/Source/web/tests/AssociatedURLLoaderTest.cpp

index 578a9a6364bf31e22fe2f7ba7b98a714aad4bc7c..2813c938857b4cb9c81c9a2a2bcaab15dc56496e 100644

--- a/Source/web/tests/AssociatedURLLoaderTest.cpp

+++ b/Source/web/tests/AssociatedURLLoaderTest.cpp

@@ -555,7 +555,7 @@ TEST_F(AssociatedURLLoaderTest, RedirectCrossOriginWithAccessControlFailure)

// We should get a notification about access control check failure.

EXPECT_FALSE(m_willSendRequest);

EXPECT_FALSE(m_didReceiveResponse);

- EXPECT_TRUE(m_didReceiveData);

+ EXPECT_FALSE(m_didReceiveData);

EXPECT_TRUE(m_didFail);

}

« no previous file with comments | « Source/core/loader/WorkerLoaderClientBridgeSyncHelper.cpp ('k') | no next file » | no next file with comments »