chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc - Issue 891213002: Add a test for the mouseleave event on window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Issue 891213002: Add a test for the mouseleave event on window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/mouseleave_browsertest.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

index 7d50614d1f37f4ce32fa06a3e99d6308a5e839d6..ae93e95b2fda6023f6dea2b59707d92d493beb41 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

@@ -254,8 +254,7 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenIncognitoNoneReferrer) {

// Check filename on clicking "Save Link As" via a "real" context menu.

IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {

// Register observer.

- SaveLinkAsContextMenuObserver menu_observer(

- content::NotificationService::AllSources());

+ ContextMenuWaiter menu_observer(content::NotificationService::AllSources());

// Go to a page with a link having download attribute.

const std::string kSuggestedFilename("test_filename.png");

@@ -277,10 +276,10 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {

tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);

// Wait for context menu to be visible.

- menu_observer.WaitForMenu();

+ menu_observer.WaitForMenuOpenAndClose();

// Compare filename.

- base::string16 suggested_filename = menu_observer.GetSuggestedFilename();

+ base::string16 suggested_filename = menu_observer.params().suggested_filename;

ASSERT_EQ(kSuggestedFilename, base::UTF16ToUTF8(suggested_filename).c_str());

}