Extract the Skia implementation of HarfBuzz font to its own file

Extract the Skia implementation of HarfBuzz font to its own file

BUG=
R=msw

Committed: https://crrev.com/42a3f824040f2a251ef13e46387b03ea3382b81a
Cr-Commit-Position: refs/heads/master@{#314975}

[ckocagil, 2015-02-03 02:38:33]

Patchset #1 (id:1) has been deleted

[ckocagil, 2015-02-03 02:42:36]

Patchset #1 (id:20001) has been deleted

[ckocagil, 2015-02-03 02:43:13]

ckocagil@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2015-02-03 20:50:33]

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
File ui/gfx/harfbuzz_font_skia.cc (right):

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
ui/gfx/harfbuzz_font_skia.cc:16: // Font data provider for HarfBuzz using Skia.
Copied from Blink.
nit: keep this comment with the FontData struct.

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
ui/gfx/harfbuzz_font_skia.cc:31: static std::map<SkFontID, FaceCache>
g_face_caches;
Can this remain a static member of CreateHarfBuzzFont?

[ckocagil, 2015-02-05 04:56:45]

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
File ui/gfx/harfbuzz_font_skia.cc (right):

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
ui/gfx/harfbuzz_font_skia.cc:16: // Font data provider for HarfBuzz using Skia.
Copied from Blink.
On 2015/02/03 20:50:32, msw wrote:
> nit: keep this comment with the FontData struct.

Done.

https://codereview.chromium.org/891183003/diff/40001/ui/gfx/harfbuzz_font_ski...
ui/gfx/harfbuzz_font_skia.cc:31: static std::map<SkFontID, FaceCache>
g_face_caches;
On 2015/02/03 20:50:32, msw wrote:
> Can this remain a static member of CreateHarfBuzzFont?

Done.

[msw, 2015-02-05 23:22:46]

lgtm

[ckocagil, 2015-02-05 23:36:09]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2015-02-05 23:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891183003/60001

[commit-bot: I haz the power, 2015-02-05 23:53:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 23:53:50]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[ckocagil, 2015-02-06 00:01:43]

New patchsets have been uploaded after l-g-t-m from msw@chromium.org

[ckocagil, 2015-02-06 00:07:49]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2015-02-06 00:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891183003/80001

[commit-bot: I haz the power, 2015-02-06 01:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 01:07:25]

Failed to apply patch for ui/gfx/gfx.gyp:
While running git apply --index -3 -p1;
  error: patch failed: ui/gfx/gfx.gyp:182
  Falling back to three-way merge...
  Applied patch to 'ui/gfx/gfx.gyp' with conflicts.
  U ui/gfx/gfx.gyp

Patch:       ui/gfx/gfx.gyp
Index: ui/gfx/gfx.gyp
diff --git a/ui/gfx/gfx.gyp b/ui/gfx/gfx.gyp
index
6fba50ada2aea4c44d2d4a231b3d4293dbe40786..52f0bf68a13fe8fbc6bc4b61afe448f4aebadd39
100644
--- a/ui/gfx/gfx.gyp
+++ b/ui/gfx/gfx.gyp
@@ -182,6 +182,8 @@
         'gfx_paths.h',
         'gpu_memory_buffer.cc',
         'gpu_memory_buffer.h',
+        'harfbuzz_font_skia.cc',
+        'harfbuzz_font_skia.h',
         'image/canvas_image_source.cc',
         'image/canvas_image_source.h',
         'image/image.cc',
@@ -388,6 +390,8 @@
         }],
         ['OS=="android" or OS=="ios"', {
           'sources!': [
+            'harfbuzz_font_skia.cc',
+            'harfbuzz_font_skia.h',
             'render_text.cc',
             'render_text.h',
             'render_text_harfbuzz.cc',

[commit-bot: I haz the power, 2015-02-06 01:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[ckocagil, 2015-02-06 02:00:18]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2015-02-06 02:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891183003/100001

[commit-bot: I haz the power, 2015-02-06 04:19:25]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-02-06 04:20:13]

Patchset 4 (id:??) landed as
https://crrev.com/42a3f824040f2a251ef13e46387b03ea3382b81a
Cr-Commit-Position: refs/heads/master@{#314975}