Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 891173005: [Metro] Set a shelf icon for the user manager. (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Metro] Set a shelf icon for the user manager. Otherwise, minimising it sends it into the void, from where it can never be recovered (unless you manually re-open it again) BUG=450959 TEST=Start Chrome with --enable-new-avatar menu, and in Metro mode. Choose "Switch Person" from the avatar menu. The window should have a shelf item. Committed: https://crrev.com/48a41be3fc0c9619197d09b97e8677ea9c866a42 Cr-Commit-Position: refs/heads/master@{#314236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/views/profiles/user_manager_view.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
PTAL. Thanks! The shelf icon looks like a folder -- From the description, it looks ...
5 years, 10 months ago (2015-02-02 23:20:28 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-03 00:18:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891173005/1
5 years, 10 months ago (2015-02-03 00:35:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 01:32:40 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:33:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a41be3fc0c9619197d09b97e8677ea9c866a42
Cr-Commit-Position: refs/heads/master@{#314236}

Powered by Google App Engine
This is Rietveld 408576698