Issue 891143002: Teach SkyShell how to draw with Ganesh

Issue 891143002: Teach SkyShell how to draw with Ganesh (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach SkyShell how to draw with Ganesh This CL adds support to SkyShell for drawing with Ganesh. Currently, we don't actually create any SkPictures to draw, but that will come in a later CL. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/59bf3828f64b929c2ca6d03187d8a2e8be57bb3a

Patch Set 1 #

Patch Set 2 : build fix #

Total comments: 4

Patch Set 3 : again #

Patch Set 4 : Moar comments #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+287 lines, -93 lines)			Patch
M	sky/shell/BUILD.gn	View		2 chunks	+8 lines, -2 lines	0 comments	Download
A	sky/shell/gpu/ganesh_context.h	View	1 2 3	1 chunk	+37 lines, -0 lines	0 comments	Download
A	sky/shell/gpu/ganesh_context.cc	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	sky/shell/gpu/ganesh_surface.h	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
A	sky/shell/gpu/ganesh_surface.cc	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
A	sky/shell/gpu/rasterizer.h	View		1 chunk	+56 lines, -0 lines	0 comments	Download
A	sky/shell/gpu/rasterizer.cc	View		1 chunk	+71 lines, -0 lines	0 comments	Download
D	sky/shell/gpu_driver.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	sky/shell/gpu_driver.cc	View		1 chunk	+0 lines, -44 lines	0 comments	Download
M	sky/shell/shell.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/shell/shell.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/891143002/diff/20001/mojo/skia/ganesh_surface.cc File mojo/skia/ganesh_surface.cc (right): https://codereview.chromium.org/891143002/diff/20001/mojo/skia/ganesh_surface.cc#newcode7 mojo/skia/ganesh_surface.cc:7: #include "base/logging.h" ? https://codereview.chromium.org/891143002/diff/20001/sky/shell/gpu/ganesh_context.h File sky/shell/gpu/ganesh_context.h (right): https://codereview.chromium.org/891143002/diff/20001/sky/shell/gpu/ganesh_context.h#newcode22 ...

5 years, 10 months ago (2015-02-01 08:31:35 UTC) #2

abarth-chromium

Thanks! https://codereview.chromium.org/891143002/diff/20001/mojo/skia/ganesh_surface.cc File mojo/skia/ganesh_surface.cc (right): https://codereview.chromium.org/891143002/diff/20001/mojo/skia/ganesh_surface.cc#newcode7 mojo/skia/ganesh_surface.cc:7: #include "base/logging.h" On 2015/02/01 at 08:31:34, eseidel wrote: ...

5 years, 10 months ago (2015-02-01 08:34:18 UTC) #3

abarth-chromium

5 years, 10 months ago (2015-02-01 08:39:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
59bf3828f64b929c2ca6d03187d8a2e8be57bb3a (presubmit successful).

Expand Messages | Collapse Messages