Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: sync/sessions/test_util.cc

Issue 891123003: Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/test_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/test_util.cc
diff --git a/sync/sessions/test_util.cc b/sync/sessions/test_util.cc
index c226a12d846072c9c8b9ba6e278d8105f1ed5064..1163ea7fcb0316bff7476a1b292507a1f621b4d5 100644
--- a/sync/sessions/test_util.cc
+++ b/sync/sessions/test_util.cc
@@ -46,22 +46,23 @@
}
void SimulateNormalSuccess(ModelTypeSet requested_types,
- sessions::NudgeTracker* nudge_tracker,
+ const sessions::NudgeTracker& nudge_tracker,
sessions::SyncSession* session) {
session->mutable_status_controller()->set_commit_result(SYNCER_OK);
session->mutable_status_controller()->set_last_download_updates_result(
SYNCER_OK);
}
-void SimulateDownloadUpdatesFailed(ModelTypeSet requested_types,
- sessions::NudgeTracker* nudge_tracker,
- sessions::SyncSession* session) {
+void SimulateDownloadUpdatesFailed(
+ ModelTypeSet requested_types,
+ const sessions::NudgeTracker& nudge_tracker,
+ sessions::SyncSession* session) {
session->mutable_status_controller()->set_last_download_updates_result(
SERVER_RETURN_TRANSIENT_ERROR);
}
void SimulateCommitFailed(ModelTypeSet requested_types,
- sessions::NudgeTracker* nudge_tracker,
+ const sessions::NudgeTracker& nudge_tracker,
sessions::SyncSession* session) {
session->mutable_status_controller()->set_last_get_key_result(SYNCER_OK);
session->mutable_status_controller()->set_last_download_updates_result(
@@ -70,9 +71,10 @@
SERVER_RETURN_TRANSIENT_ERROR);
}
-void SimulateConnectionFailure(ModelTypeSet requested_types,
- sessions::NudgeTracker* nudge_tracker,
- sessions::SyncSession* session) {
+void SimulateConnectionFailure(
+ ModelTypeSet requested_types,
+ const sessions::NudgeTracker& nudge_tracker,
+ sessions::SyncSession* session) {
session->mutable_status_controller()->set_last_download_updates_result(
NETWORK_CONNECTION_UNAVAILABLE);
}
@@ -116,7 +118,7 @@
void SimulateSessionsCommitDelayUpdateImpl(
ModelTypeSet requested_types,
- sessions::NudgeTracker* nudge_tracker,
+ const sessions::NudgeTracker& nudge_tracker,
sessions::SyncSession* session,
const base::TimeDelta& new_delay) {
SimulateNormalSuccess(requested_types, nudge_tracker, session);
« no previous file with comments | « sync/sessions/test_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698