Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: sync/sessions/data_type_tracker.cc

Issue 891123003: Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/data_type_tracker.h ('k') | sync/sessions/nudge_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/data_type_tracker.cc
diff --git a/sync/sessions/data_type_tracker.cc b/sync/sessions/data_type_tracker.cc
index 8103c003db710c440f1afca37abbc4e1c22ef9e2..da50bbfb4c5da3ba005ea8214aa7e2a0dcb908de 100644
--- a/sync/sessions/data_type_tracker.cc
+++ b/sync/sessions/data_type_tracker.cc
@@ -15,8 +15,7 @@
: local_nudge_count_(0),
local_refresh_request_count_(0),
payload_buffer_size_(NudgeTracker::kDefaultMaxPayloadsPerType),
- initial_sync_required_(false),
- sync_required_to_resolve_conflict_(false) {
+ initial_sync_required_(false) {
}
DataTypeTracker::~DataTypeTracker() { }
@@ -93,10 +92,6 @@
initial_sync_required_ = true;
}
-void DataTypeTracker::RecordCommitConflict() {
- sync_required_to_resolve_conflict_ = true;
-}
-
void DataTypeTracker::RecordSuccessfulSyncCycle() {
// If we were throttled, then we would have been excluded from this cycle's
// GetUpdates and Commit actions. Our state remains unchanged.
@@ -124,7 +119,6 @@
}
initial_sync_required_ = false;
- sync_required_to_resolve_conflict_ = false;
}
// This limit will take effect on all future invalidations received.
@@ -139,7 +133,7 @@
bool DataTypeTracker::IsGetUpdatesRequired() const {
return !IsThrottled() &&
(HasRefreshRequestPending() || HasPendingInvalidation() ||
- IsInitialSyncRequired() || IsSyncRequiredToResolveConflict());
+ IsInitialSyncRequired());
}
bool DataTypeTracker::HasLocalChangePending() const {
@@ -156,10 +150,6 @@
bool DataTypeTracker::IsInitialSyncRequired() const {
return initial_sync_required_;
-}
-
-bool DataTypeTracker::IsSyncRequiredToResolveConflict() const {
- return sync_required_to_resolve_conflict_;
}
void DataTypeTracker::SetLegacyNotificationHint(
@@ -202,8 +192,6 @@
msg->set_local_modification_nudges(local_nudge_count_);
msg->set_datatype_refresh_nudges(local_refresh_request_count_);
msg->set_initial_sync_in_progress(initial_sync_required_);
- msg->set_sync_for_resolve_conflict_in_progress(
- sync_required_to_resolve_conflict_);
}
bool DataTypeTracker::IsThrottled() const {
« no previous file with comments | « sync/sessions/data_type_tracker.h ('k') | sync/sessions/nudge_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698