sync/engine/syncer.h - Issue 891123003: Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/syncer.h

Issue 891123003: Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/syncer.h

diff --git a/sync/engine/syncer.h b/sync/engine/syncer.h

index ca93b360820c97166775209d089a7fad9731c1e7..02e66e39c7086ba8eb32c1a20944e32368f5a152 100644

--- a/sync/engine/syncer.h

+++ b/sync/engine/syncer.h

@@ -48,7 +48,7 @@

// sync. The |nudge_tracker| contains state that describes why the client is

// out of sync and what must be done to bring it back into sync.

virtual bool NormalSyncShare(ModelTypeSet request_types,

- sessions::NudgeTracker* nudge_tracker,

+ const sessions::NudgeTracker& nudge_tracker,

sessions::SyncSession* session);

// Performs an initial download for the |request_types|. It is assumed that

@@ -79,10 +79,10 @@

// number of unsynced and ready to commit items reaches zero or an error is

// encountered. A request to exit early will be treated as an error and will

// abort any blocking operations.

- SyncerError BuildAndPostCommits(ModelTypeSet request_types,

- sessions::NudgeTracker* nudge_tracker,

- sessions::SyncSession* session,

- CommitProcessor* commit_processor);

+ SyncerError BuildAndPostCommits(

+ ModelTypeSet request_types,

+ sessions::SyncSession* session,

+ CommitProcessor* commit_processor);

void HandleCycleBegin(sessions::SyncSession* session);

bool HandleCycleEnd(

« no previous file with comments | « sync/engine/sync_scheduler_unittest.cc ('k') | sync/engine/syncer.cc » ('j') | no next file with comments »