Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891113002: Cleanup: Fix some unused-function warnings. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -69 lines) Patch
M core/src/fpdfapi/fpdf_basic_module.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 2 4 chunks +16 lines, -16 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
5 years, 10 months ago (2015-01-31 03:24:52 UTC) #3
Tom Sepez
LGTM. Do any of these happen to be used in XFA? Curious. Also, I'd been ...
5 years, 10 months ago (2015-02-02 18:48:36 UTC) #4
Lei Zhang
Doesn't look used in the xfa branch either. https://codereview.chromium.org/891113002/diff/20001/core/src/fpdfdoc/doc_basic.cpp File core/src/fpdfdoc/doc_basic.cpp (right): https://codereview.chromium.org/891113002/diff/20001/core/src/fpdfdoc/doc_basic.cpp#newcode352 core/src/fpdfdoc/doc_basic.cpp:352: #if ...
5 years, 10 months ago (2015-02-07 00:51:30 UTC) #5
Lei Zhang
5 years, 10 months ago (2015-02-07 00:51:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as
44fc192f29a77c5864fabffe5ab63937dacdfd21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698