Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 891063002: Make --site-per-process override --process-per-tab in RFHM::ShouldTransitionCrossSite (Closed)

Created:
5 years, 10 months ago by alexmos
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make --site-per-process override --process-per-tab in RFHM::ShouldTransitionCrossSite. This is necessary so that layout tests can run with --site-per-process. Layout tests run with --dump-render-tree, which also forces --process-per-tab, and the latter was conflicting with --site-per-process. BUG=417518 Committed: https://crrev.com/3180ced2f2cfd98fee64a48bef2dc460fa229243 Cr-Commit-Position: refs/heads/master@{#314985}

Patch Set 1 : Experiment with removing kProcessPerTab completely #

Patch Set 2 : Overriding kProcessPerTab in ShouldTransitionCrossSite only #

Total comments: 2

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alexmos
Charlie, could you please take a look?
5 years, 10 months ago (2015-02-05 17:51:45 UTC) #2
Charlie Reis
LGTM https://codereview.chromium.org/891063002/diff/20001/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/891063002/diff/20001/content/browser/frame_host/render_frame_host_manager.cc#newcode851 content/browser/frame_host/render_frame_host_manager.cc:851: // True for --site-per-process, which overrides both kSingleProcess ...
5 years, 10 months ago (2015-02-05 17:57:53 UTC) #3
alexmos
Thanks! https://codereview.chromium.org/891063002/diff/20001/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/891063002/diff/20001/content/browser/frame_host/render_frame_host_manager.cc#newcode851 content/browser/frame_host/render_frame_host_manager.cc:851: // True for --site-per-process, which overrides both kSingleProcess ...
5 years, 10 months ago (2015-02-05 18:01:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891063002/40001
5 years, 10 months ago (2015-02-06 05:17:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-06 06:12:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 06:13:38 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3180ced2f2cfd98fee64a48bef2dc460fa229243
Cr-Commit-Position: refs/heads/master@{#314985}

Powered by Google App Engine
This is Rietveld 408576698