net/ftp/ftp_network_transaction.h - Issue 891013002: Clean up FTPNetworkTransaction to match the latest trace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_network_transaction.h

Issue 891013002: Clean up FTPNetworkTransaction to match the latest trace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_network_transaction.h

diff --git a/net/ftp/ftp_network_transaction.h b/net/ftp/ftp_network_transaction.h

index fc94ae78f53586b388466a6f803ca85553d3813a..0ca5150c220aaf69ad1ce13f6208c93bcbe6e182 100644

--- a/net/ftp/ftp_network_transaction.h

+++ b/net/ftp/ftp_network_transaction.h

@@ -34,7 +34,6 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction {

~FtpNetworkTransaction() override;

virtual int Stop(int error);

davidben 2015/02/04 18:51:18 While you're here, is there any reason this is vir

xunjieli 2015/02/04 20:29:29 Done. Agreed, there should not be a virtual modifi

- virtual int RestartIgnoringLastError(const CompletionCallback& callback);

// FtpTransaction methods:

int Start(const FtpRequestInfo* request_info,

« no previous file with comments | « no previous file | net/ftp/ftp_network_transaction.cc » ('j') | net/ftp/ftp_network_transaction.cc » ('J')