Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 891003003: Fix IXFA_ destructor compiler warnings. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix IXFA_ destructor compiler warnings. On the XFA branch, there are still some of these warnings that were fixed (mostly) in master. Correct a few more of these. Also tidy a few needless returns. R=brucedawson@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d3e247709404e2793ff1c7a6a03e62c7349b2f06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M xfa/include/fxfa/fxfa.h View 13 chunks +29 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Bruce, PTAL.
5 years, 10 months ago (2015-01-30 20:00:57 UTC) #2
brucedawson
lgtm
5 years, 10 months ago (2015-01-30 23:01:41 UTC) #3
Tom Sepez
5 years, 10 months ago (2015-01-30 23:02:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3e247709404e2793ff1c7a6a03e62c7349b2f06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698