Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 890963002: Revert of cc: Stop pushing properties every activation for picture layers. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Stop pushing properties every activation for picture layers. (patchset #3 id:40001 of https://codereview.chromium.org/874613003/) Reason for revert: flaky tests https://code.google.com/p/chromium/issues/detail?id=452965 Original issue's description: > cc: Stop pushing properties every activation for picture layers. > > Since we don't swap tilings anymore, we only need to push properties > when a property, or a tiling, or the raster source (invalidation) has > changed. > > R=vmpstr > BUG=303943 > > Committed: https://crrev.com/dcaa923e704847eb6ba7003602ff70579aaaf47e > Cr-Commit-Position: refs/heads/master@{#313329} TBR=vmpstr@chromium.org,enne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=303943 Committed: https://crrev.com/d6abedbc881cd740d76f80f1c89bd1e737b07e7a Cr-Commit-Position: refs/heads/master@{#313935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -180 lines) Patch
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 6 chunks +4 lines, -161 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Created Revert of cc: Stop pushing properties every activation for picture layers.
5 years, 10 months ago (2015-01-30 17:33:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890963002/1
5 years, 10 months ago (2015-01-30 17:33:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 17:35:04 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:36:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6abedbc881cd740d76f80f1c89bd1e737b07e7a
Cr-Commit-Position: refs/heads/master@{#313935}

Powered by Google App Engine
This is Rietveld 408576698