Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 890893003: Reland "remove unused SkAvoidXfermode" (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland "remove unused SkAvoidXfermode" (patchset #2 id:20001 of https://codereview.chromium.org/860583002/) SkAvoidXfermode has been moved into Android, so it is safe to remove. Committed: https://skia.googlesource.com/skia/+/e7ea40f4e0ef9f5405c256432fde87f521a9a2ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -371 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/effects/SkAvoidXfermode.h View 1 chunk +0 lines, -68 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleAll.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
D samplecode/SampleAvoid.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
D src/effects/SkAvoidXfermode.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
scroggo
Created Revert of Revert of remove unused SkAvoidXfermode
5 years, 10 months ago (2015-01-30 13:58:55 UTC) #1
scroggo
Mike, Android no longer needs this, so safe to remove.
5 years, 10 months ago (2015-01-30 14:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890893003/1
5 years, 10 months ago (2015-01-30 15:10:06 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 15:10:07 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-01-30 21:10:08 UTC) #8
reed1
lgtm
5 years, 10 months ago (2015-01-30 21:15:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890893003/1
5 years, 10 months ago (2015-01-30 21:15:46 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 21:16:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e7ea40f4e0ef9f5405c256432fde87f521a9a2ef

Powered by Google App Engine
This is Rietveld 408576698