Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 890883006: Cleanup parts of fpdf_render_loadimage.cpp. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup parts of fpdf_render_loadimage.cpp. - Add functions to do pitch calculation. - Delete dead code. - Don't bother checking pointers before deleting them. - Don't bother setting pointers to NULL in dtors. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3f41851972a18762164d7110a82da3baed564b80

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -130 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 20 chunks +69 lines, -126 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 2 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
5 years, 10 months ago (2015-01-31 02:43:16 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render/render_int.h File core/src/fpdfapi/fpdf_render/render_int.h (right): https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render/render_int.h#newcode417 core/src/fpdfapi/fpdf_render/render_int.h:417: FX_BOOL LoadColorInfo(CPDF_Dictionary* pFormResources, CPDF_Dictionary* pPageResources); nit: I'd be ...
5 years, 10 months ago (2015-02-02 22:55:45 UTC) #3
Lei Zhang
https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render/render_int.h File core/src/fpdfapi/fpdf_render/render_int.h (right): https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render/render_int.h#newcode417 core/src/fpdfapi/fpdf_render/render_int.h:417: FX_BOOL LoadColorInfo(CPDF_Dictionary* pFormResources, CPDF_Dictionary* pPageResources); On 2015/02/02 22:55:45, Tom ...
5 years, 10 months ago (2015-02-07 00:44:01 UTC) #4
Lei Zhang
5 years, 10 months ago (2015-02-07 00:44:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3f41851972a18762164d7110a82da3baed564b80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698