Cleanup parts of fpdf_render_loadimage.cpp.

Cleanup parts of fpdf_render_loadimage.cpp.

- Add functions to do pitch calculation.
- Delete dead code.
- Don't bother checking pointers before deleting them.
- Don't bother setting pointers to NULL in dtors.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3f41851972a18762164d7110a82da3baed564b80

[Lei Zhang, 2015-01-31 02:43:16]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-02-02 22:55:45]

lgtm

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
File core/src/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:417: FX_BOOL
LoadColorInfo(CPDF_Dictionary* pFormResources, CPDF_Dictionary* pPageResources);
nit: I'd be tempted not to re-indent this to allow for merges from FX.

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:431: FX_DWORD m_Family, m_bpc,
m_bpc_orig, m_nComponents, m_GroupFamily;
nit: as long as you're mucking with this, how about one declaration per line.

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:433: FX_BOOL m_bDefaultDecode,
m_bImageMask, m_bColorKey;
nit: here too.

[Lei Zhang, 2015-02-07 00:44:01]

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
File core/src/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:417: FX_BOOL
LoadColorInfo(CPDF_Dictionary* pFormResources, CPDF_Dictionary* pPageResources);
On 2015/02/02 22:55:45, Tom Sepez wrote:
> nit: I'd be tempted not to re-indent this to allow for merges from FX.

Ok, I left it alone.

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:431: FX_DWORD m_Family, m_bpc,
m_bpc_orig, m_nComponents, m_GroupFamily;
On 2015/02/02 22:55:45, Tom Sepez wrote:
> nit: as long as you're mucking with this, how about one declaration per line.

Done.

https://codereview.chromium.org/890883006/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/render_int.h:433: FX_BOOL m_bDefaultDecode,
m_bImageMask, m_bColorKey;
On 2015/02/02 22:55:45, Tom Sepez wrote:
> nit: here too.

Done.

[Lei Zhang, 2015-02-07 00:44:17]

Committed patchset #3 (id:40001) manually as
3f41851972a18762164d7110a82da3baed564b80 (presubmit successful).