Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890873004: ProfileInfoCache: Don't delete ProfileAvatarDownloader while we're being called by it (Closed)

Created:
5 years, 10 months ago by Marc Treib
Modified:
5 years, 10 months ago
Reviewers:
noms (inactive), gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ProfileInfoCache: Don't delete ProfileAvatarDownloader while we're being called by it BUG=453795 Committed: https://crrev.com/af25550b46f4aaf597420638aa895db7ebe2657f Cr-Commit-Position: refs/heads/master@{#313937}

Patch Set 1 #

Total comments: 3

Patch Set 2 : comment #

Patch Set 3 : fix test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 3 chunks +16 lines, -4 lines 1 comment Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Marc Treib
PTAL!
5 years, 10 months ago (2015-01-30 15:59:08 UTC) #2
noms (inactive)
Thanks so much! lgtm % nit. https://codereview.chromium.org/890873004/diff/1/chrome/browser/profiles/profile_info_cache.cc File chrome/browser/profiles/profile_info_cache.cc (right): https://codereview.chromium.org/890873004/diff/1/chrome/browser/profiles/profile_info_cache.cc#newcode151 chrome/browser/profiles/profile_info_cache.cc:151: void DeleteDownloader(ProfileAvatarDownloader* downloader) ...
5 years, 10 months ago (2015-01-30 16:05:40 UTC) #3
Marc Treib
https://codereview.chromium.org/890873004/diff/1/chrome/browser/profiles/profile_info_cache.cc File chrome/browser/profiles/profile_info_cache.cc (right): https://codereview.chromium.org/890873004/diff/1/chrome/browser/profiles/profile_info_cache.cc#newcode151 chrome/browser/profiles/profile_info_cache.cc:151: void DeleteDownloader(ProfileAvatarDownloader* downloader) { On 2015/01/30 16:05:40, Monica Dinculescu ...
5 years, 10 months ago (2015-01-30 16:12:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890873004/20001
5 years, 10 months ago (2015-01-30 16:13:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890873004/40001
5 years, 10 months ago (2015-01-30 17:07:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 17:48:25 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/af25550b46f4aaf597420638aa895db7ebe2657f Cr-Commit-Position: refs/heads/master@{#313937}
5 years, 10 months ago (2015-01-30 17:49:15 UTC) #10
gab
5 years, 10 months ago (2015-02-03 18:20:17 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/890873004/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_info_cache.cc (right):

https://codereview.chromium.org/890873004/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/profile_info_cache.cc:919: downloader_iter->second));
FYI,
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, download_iter->second);
provides this exact functionality without having to implement your own delete
helper.

Powered by Google App Engine
This is Rietveld 408576698