Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 890853002: Revert of text-combine should scale rather than fall back to none when wide (Closed)

Created:
5 years, 10 months ago by vsevik
Modified:
5 years, 10 months ago
Reviewers:
CC:
blink-reviews, dshwang, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, Dominik Röttsches, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of text-combine should scale rather than fall back to none when wide (patchset #5 id:180001 of https://codereview.chromium.org/799123003/) Reason for revert: Makes fast/text/text-combine-selection-crash.html crash on mac: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Ftext-combine-selection-crash.html&testType=layout-tests Also revert "Auto-rebaseline for r189235" (https://codereview.chromium.org/886963003) Original issue's description: > text-combine should scale rather than fall back to none when wide > > This patch follows the CSS spec change in 2014 CR: > Old: Combine if vertical flow and its width <= ~1em > Current: Combine if vertical flow. Scale if width > ~1em > > CR: http://www.w3.org/TR/css-writing-modes-3/#text-combine > ED: http://dev.w3.org/csswg/css-writing-modes/#text-combine > > In addition to the changes to RenderCombineText, this spec change has a > small but pleasant side effect to our implementation. The > RenderCombinedText delays the width calculation until it's needed. But the > spec also says that it has to be treated as an U+FFFC OBJECT REPLACEMENT > CHARACTER to line breakers when combined. > > From these two facts, line breakers must be aware of RenderCombinedText and > update it (combineText()) when needed. Also, the fact that combineText() > could change the length of text brought additional complexity. We have a > few calls to combineText() in line breakers, and still has some flakiness > such as bug 312606. The new spec eliminates this complexity, so our line > breakers are a bit cleaner, faster, and less flaky. > > fast/text/font-variant-width.html had to be rewritten because it relied on > the behavior of text-combine to fallback when wide. > > BUG=433176, 312606 > TEST=fast/writing-mode/text-combine-compress.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189235 TBR=kouhei@chromium.org,leviw@chromium.org,kojii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433176, 312606 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1347 lines, -2327 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dynamic/text-combine.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/text/font-variant-width.html View 2 chunks +37 lines, -43 lines 0 comments Download
M LayoutTests/fast/text/font-variant-width-expected.txt View 1 chunk +22 lines, -14 lines 0 comments Download
M LayoutTests/fast/text/international/combine-at-line-break-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/writing-mode/text-combine-compress.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/writing-mode/text-combine-compress-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/platform/android/fast/dynamic/text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/dynamic/text-combine-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/android/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
M LayoutTests/platform/linux/fast/dynamic/text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/dynamic/text-combine-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/linux/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +80 lines, -80 lines 0 comments Download
M LayoutTests/platform/linux/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +87 lines, -87 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +87 lines, -87 lines 0 comments Download
A LayoutTests/platform/mac-lion/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt View 1 chunk +128 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac-lion/virtual/antialiasedtext/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/virtual/antialiasedtext/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/dynamic/text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/dynamic/text-combine-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/mac/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +40 lines, -40 lines 0 comments Download
M LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +70 lines, -70 lines 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +40 lines, -40 lines 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/international/text-combine-image-test-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/dynamic/text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/dynamic/text-combine-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +80 lines, -80 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +88 lines, -88 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
M LayoutTests/platform/win/fast/dynamic/text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/dynamic/text-combine-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +80 lines, -80 lines 0 comments Download
M LayoutTests/platform/win/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +84 lines, -84 lines 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/decorations-with-text-combine-expected.txt View 8 chunks +80 lines, -80 lines 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +84 lines, -84 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/fast/text/decorations-with-text-combine-expected.txt View 1 chunk +0 lines, -153 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/text/international/text-combine-image-test-expected.txt View 2 chunks +84 lines, -84 lines 0 comments Download
A + LayoutTests/virtual/antialiasedtext/fast/text/font-variant-width-expected.txt View 1 chunk +13 lines, -9 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +5 lines, -15 lines 0 comments Download
M Source/core/paint/TextPainter.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderCombineText.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/rendering/RenderCombineText.cpp View 5 chunks +38 lines, -66 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/rendering/line/LineBreaker.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsevik
5 years, 10 months ago (2015-01-30 10:04:43 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 189239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698