third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py - Issue 890843003: Revert of Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py

Issue 890843003: Revert of Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/mojom.gni ('k') | third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py

index 3d0ac2e2c3f09fdc3f7636bbd1ab129dbc6917ff..3a415932c4e0945ba77e1530a52c4a01a728af6f 100644

--- a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py

+++ b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py

@@ -364,7 +364,6 @@

scope = (module.namespace, )

# TODO(mpcomplete): maybe we should only support POD kinds.

constant.kind = KindFromData(module.kinds, data['kind'], scope)

- constant.parent_kind = parent_kind

constant.value = FixupExpression(module, data.get('value'), scope, None)

value = mojom.ConstantValue(module, parent_kind, constant)

@@ -410,7 +409,7 @@

module.structs = map(

lambda struct: StructFromData(module, struct), data['structs'])

module.unions = map(

- lambda union: UnionFromData(module, union), data.get('unions', []))

+ lambda union: UnionFromData(module, struct), data.get('unions', []))

module.interfaces = map(

lambda interface: InterfaceFromData(module, interface),

data['interfaces'])