third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc - Issue 890843003: Revert of Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc

Issue 890843003: Revert of Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo_services/src/public/js/shell.js ('k') | third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc

diff --git a/third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc b/third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc

index 4a7007220e87f2f1385d6e31851af60b2863cc7d..ba3b61ca147ddd18d8a63a82dd717b0ec62efaf3 100644

--- a/third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc

+++ b/third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc

@@ -387,8 +387,6 @@

ViewportMetricsPtr CreateEmptyViewportMetrics() {

ViewportMetricsPtr metrics = ViewportMetrics::New();

metrics->size = Size::New();

- // TODO(vtl): The |.Pass()| below is only needed due to an MSVS bug; remove it

- // once that's fixed.

return metrics.Pass();

}