SkyShell should be able to draw a green square with GL

SkyShell should be able to draw a green square with GL

This CL teaches SkyShell how to initialize GL and draw a green square.

R=eseidel@google.com, eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/5ed7eaf6afa52a0caa6df2205a6977c99962d1e1

[eseidel1, 2015-01-31 07:42:49]

eseidel@google.com changed reviewers:
+ eseidel@google.com

[eseidel1, 2015-01-31 07:42:50]

lgtm

looks reasonable.

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
File sky/shell/apk/src/org/domokit/sky/shell/SkyView.java (right):

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
sky/shell/apk/src/org/domokit/sky/shell/SkyView.java:25:
@SuppressWarnings("unused")
That's right, you tell them who's boss.

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
sky/shell/apk/src/org/domokit/sky/shell/SkyView.java:38: assert mNativeSkyView
!= 0;
What happened to your parenthesis java?

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
sky/shell/apk/src/org/domokit/sky/shell/SkyView.java:49: @Override
capital override?

https://codereview.chromium.org/890803004/diff/1/sky/shell/library_loader.cc
File sky/shell/library_loader.cc (left):

https://codereview.chromium.org/890803004/diff/1/sky/shell/library_loader.cc#...
sky/shell/library_loader.cc:14: base::android::RegistrationMethod
kSkyRegisteredMethods[] = {
I'm not sure what this does.

[abarth-chromium, 2015-01-31 07:51:54]

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
File sky/shell/apk/src/org/domokit/sky/shell/SkyView.java (right):

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
sky/shell/apk/src/org/domokit/sky/shell/SkyView.java:38: assert mNativeSkyView
!= 0;
On 2015/01/31 at 07:42:50, eseidel1 wrote:
> What happened to your parenthesis java?

I think assert is a keyword

https://codereview.chromium.org/890803004/diff/1/sky/shell/apk/src/org/domoki...
sky/shell/apk/src/org/domokit/sky/shell/SkyView.java:49: @Override
On 2015/01/31 at 07:42:49, eseidel1 wrote:
> capital override?

Yep.  That's how Java rolls.

https://codereview.chromium.org/890803004/diff/1/sky/shell/library_loader.cc
File sky/shell/library_loader.cc (right):

https://codereview.chromium.org/890803004/diff/1/sky/shell/library_loader.cc#...
sky/shell/library_loader.cc:15: base::android::RegistrationMethod
kSkyRegisteredMethods[] = {
On 2015/01/31 at 07:42:50, eseidel1 wrote:
> I'm not sure what this does.

This table is used at startup to create a JNI bridge between the Java objects
and the C++ objects.  Specifically, these register functions install the
addresses of the C++ end points we write into the autogenerated JNI code.

[abarth-chromium, 2015-01-31 08:44:50]

Committed patchset #1 (id:1) manually as
5ed7eaf6afa52a0caa6df2205a6977c99962d1e1 (presubmit successful).