Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 890803003: Update DEPS to better bootstrap 'cros_chromite.py' (Closed)

Created:
5 years, 10 months ago by dnj
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Update DEPS to better bootstrap 'cros_chromite.py' This fixes two problems with the current setup: - The `runhooks' aren't being executed on slaves because the default "recursion" value rules them out. - The script is failing on Windows bots because the Python invocation isn't working. BUG=414436 TEST=local - Ran in local context, seems to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M DEPS View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnj
PTAL
5 years, 10 months ago (2015-01-30 19:21:47 UTC) #2
Peter Mayo
lgtm
5 years, 10 months ago (2015-01-30 19:25:46 UTC) #3
Sébastien Marchand
Thanks ! LGTM.
5 years, 10 months ago (2015-01-30 19:38:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890803003/1
5 years, 10 months ago (2015-01-30 19:40:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293879
5 years, 10 months ago (2015-01-30 19:41:31 UTC) #8
dnj
5 years, 10 months ago (2015-01-30 19:47:58 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/889963003/ by dnj@chromium.org.

The reason for reverting is: This is breaking 'gclient sync'..

Powered by Google App Engine
This is Rietveld 408576698