testing/legion/examples/hello_world/client_test.isolate - Issue 890773003: Adding the initial code for Omnibot multi-machine support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/legion/examples/hello_world/client_test.isolate

Issue 890773003: Adding the initial code for Omnibot multi-machine support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing initial comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« testing/legion/discovery_server.py ('K') | « testing/legion/discovery_server.py ('k') | testing/legion/examples/hello_world/client_test.py » ('j') | testing/legion/examples/hello_world/host_test.isolate » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

	4

4 {	5 {

5 'includes': [	6 'includes': [

6 'angle.isolate',	7 '../../legion.isolate'

7 ],	8 ],

8 'conditions': [	9 'conditions': [

9 ['OS=="win"', {	10 ['os=="Linux" or os=="Windows" or os=="Mac" and multi_machine == 1', {
	Marc-Antoine Ruel (Google) 2015/01/30 21:58:40 No need to check for os at all, just: ['multi_mach No need to check for os at all, just: ['multi_machine=1', { Mike Meade 2015/02/03 01:18:09 Done. Show quoted text On 2015/01/30 21:58:40, Marc-Antoine Ruel (Google) wrote: > No need to check for os at all, just: > ['multi_machine=1', { Done.
10 'variables': {	11 'variables': {

11 'command': [	12 'command': [

12 '<(PRODUCT_DIR)/angle_end2end_tests<(EXECUTABLE_SUFFIX)',	13 '../../client_controller.py',

13 ],	14 ],

14 'files': [	15 'files': [

15 '<(PRODUCT_DIR)/angle_end2end_tests<(EXECUTABLE_SUFFIX)',	16 'client_test.py'

16 ],	17 ],

17 },	18 },

18 }],	19 }],

19 ],	20 ],

20 }	21 }

OLD	NEW