Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890753002: Adds Virtual Keyboard error rate metrics. (Closed)

Created:
5 years, 10 months ago by rsadam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds Virtual Keyboard error rate metrics. BUG=453635 Committed: https://crrev.com/f928d6bc4aa669456b99340ef2bcc8e66b0cbf2c Cr-Commit-Position: refs/heads/master@{#313936}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
rsadam
Hi, PTAL!
5 years, 10 months ago (2015-01-29 23:36:30 UTC) #1
rsadam
Forgot to add reviewer. PTAL Alexei!
5 years, 10 months ago (2015-01-30 00:09:50 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/890753002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/890753002/diff/1/tools/metrics/histograms/histograms.xml#newcode10844 tools/metrics/histograms/histograms.xml:10844: + <summary>The number of words typed per minute.</summary> Mention ...
5 years, 10 months ago (2015-01-30 00:47:22 UTC) #4
rsadam
On 2015/01/30 00:47:22, Alexei Svitkine wrote: > https://codereview.chromium.org/890753002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/890753002/diff/1/tools/metrics/histograms/histograms.xml#newcode10844 ...
5 years, 10 months ago (2015-01-30 15:58:20 UTC) #5
rsadam
5 years, 10 months ago (2015-01-30 15:58:25 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-30 16:39:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890753002/20001
5 years, 10 months ago (2015-01-30 16:40:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 17:38:58 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:40:07 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f928d6bc4aa669456b99340ef2bcc8e66b0cbf2c
Cr-Commit-Position: refs/heads/master@{#313936}

Powered by Google App Engine
This is Rietveld 408576698