Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 8907027: Line breaks are lost when pasted into textarea text starting with a blank line set while textarea... (Closed)

Created:
9 years, 2 months ago by rniwa-cr
Modified:
9 years, 2 months ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden https://bugs.webkit.org/show_bug.cgi?id=74126 Reviewed by Tony Chang. The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment pasted into textarea even though serialization algorithm in textarea doesn't handle block elements. Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this whole pre-rendering trick. * editing/markup.cpp: (WebCore::createFragmentFromText): Merge 102392 - Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden https://bugs.webkit.org/show_bug.cgi?id=74126 Reviewed by Tony Chang. The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment pasted into textarea even though serialization algorithm in textarea doesn't handle block elements. Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this whole pre-rendering trick. * editing/markup.cpp: (WebCore::createFragmentFromText): http://crbug.com/104620 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2037 lines) Patch
A + LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -2037 lines 0 comments Download
M Source/WebCore/editing/markup.cpp View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
9 years, 2 months ago (2011-12-14 01:51:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698