[Mac] The Switch Person button can be moar accessible

chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/profiles/avatar_button_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_manager.h"
@@ skipping 102 matching lines @@
     imageIds = kHoverBorderImageIds;
   ui::DrawNinePartImage(frame, imageIds, NSCompositeSourceOver, 1.0, true);
 }
 
 - (void)setIsThemedWindow:(BOOL)isThemedWindow {
   isThemedWindow_ = isThemedWindow;
 }
 
 - (void)setHasError:(BOOL)hasError withTitle:(NSString*)title {
   hasError_ = hasError;
-  if (hasError) {
-    [self accessibilitySetOverrideValue:l10n_util::GetNSStringF(
-        IDS_PROFILES_ACCOUNT_BUTTON_AUTH_ERROR_ACCESSIBLE_NAME,
-        base::SysNSStringToUTF16(title))
-                           forAttribute:NSAccessibilityTitleAttribute];
-  } else {
-    [self accessibilitySetOverrideValue:title
-                           forAttribute:NSAccessibilityTitleAttribute];
-  }
+  int messageId = hasError ?
+      IDS_PROFILES_ACCOUNT_BUTTON_AUTH_ERROR_ACCESSIBLE_NAME :
+      IDS_PROFILES_NEW_AVATAR_BUTTON_ACCESSIBLE_NAME;
+
+  [self accessibilitySetOverrideValue:l10n_util::GetNSStringF(
+      messageId, base::SysNSStringToUTF16(title))
+                         forAttribute:NSAccessibilityTitleAttribute];
 }
 
 @end
 
 @interface AvatarButtonController (Private)
 - (void)updateAvatarButtonAndLayoutParent:(BOOL)layoutParent;
 - (void)updateErrorStatus:(BOOL)hasError;
 - (void)dealloc;
 - (void)themeDidChangeNotification:(NSNotification*)aNotification;
 @end
@@ skipping 10 matching lines @@
         [[HoverImageButton alloc] initWithFrame:NSZeroRect];
     button_.reset(hoverButton);
     base::scoped_nsobject<CustomThemeButtonCell> cell(
         [[CustomThemeButtonCell alloc] initWithThemedWindow:isThemedWindow_]);
     [button_ setCell:cell.get()];
 
     // Check if the account already has an authentication error.
     SigninErrorController* errorController =
         profiles::GetSigninErrorController(browser->profile());
     hasError_ = errorController && errorController->HasError();
-    [cell setHasError:hasError_ withTitle:nil];
 
     [button_ setWantsLayer:YES];
     [self setView:button_];
 
     [button_ setBezelStyle:NSShadowlessSquareBezelStyle];
     [button_ setButtonType:NSMomentaryChangeButton];
     [button_ setBordered:YES];
 
     [button_ setAutoresizingMask:NSViewMinXMargin | NSViewMinYMargin];
     [button_ setTarget:self];
@@ skipping 53 matching lines @@
   // instead of the profile name. Never use the generic button if the active
   // profile is Guest.
   bool useGenericButton = (!browser_->profile()->IsGuestSession() &&
                            cache.GetNumberOfProfiles() == 1 &&
                            cache.GetUserNameOfProfileAtIndex(0).empty());
 
 
   NSString* buttonTitle = base::SysUTF16ToNSString(useGenericButton ?
       base::string16() :
       profiles::GetAvatarButtonTextForProfile(browser_->profile()));
+  [[button_ cell] setHasError:hasError_ withTitle:buttonTitle];
 
   HoverImageButton* button =
       base::mac::ObjCCastStrict<HoverImageButton>(button_);
   if (useGenericButton) {
     [button setDefaultImage:GetImageFromResourceID(
         IDR_AVATAR_MAC_BUTTON_AVATAR)];
     [button setHoverImage:GetImageFromResourceID(
         IDR_AVATAR_MAC_BUTTON_AVATAR_HOVER)];
     [button setPressedImage:GetImageFromResourceID(
         IDR_AVATAR_MAC_BUTTON_AVATAR_PRESSED)];
@@ skipping 34 matching lines @@
     // Because the width of the button might have changed, the parent browser
     // frame needs to recalculate the button bounds and redraw it.
     [[BrowserWindowController
         browserWindowControllerForWindow:browser_->window()->GetNativeWindow()]
         layoutSubviews];
   }
 }
 
 - (void)updateErrorStatus:(BOOL)hasError {
   hasError_ = hasError;
-  [[button_ cell] setHasError:hasError withTitle:[button_ title]];
   [self updateAvatarButtonAndLayoutParent:YES];
 }
 
 @end