Fix buffer overflow due to unbounded strlen over a non-null terminated string. Detected by asan.

Fix buffer overflow due to unbounded strlen over the non-null terminated audio policy string. Caught by asan.

BUG=

Committed: https://crrev.com/e6b0fbf6516ff2731f4f55f1bbbc1e920d6f124a
Cr-Commit-Position: refs/heads/master@{#314019}

[Kevin M, 2015-01-29 17:58:37]

kmarshall@chromium.org changed reviewers:
+ mfoltz@chromium.org, vadimgo@chromium.org

[mark a. foltz, 2015-01-29 19:43:08]

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_auth_util.cc (right):

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:23: const char
kAudioOnlyPolicy[] =
This has to remain unsigned right?  It breaks compilation on Windows.

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\extensions\browser\api\cast_channel\extensions_browser.cast_auth_util.obj.rsp
/c ..\..\extensions\browser\api\cast_channel\cast_auth_util.cc
/Foobj\extensions\browser\api\cast_channel\extensions_browser.cast_auth_util.obj
/Fdobj\extensions\extensions_browser.cc.pdb 
e:\b\build\slave\win\build\src\extensions\browser\api\cast_channel\cast_auth_util.cc(24)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\extensions\browser\api\cast_channel\cast_auth_util.cc(24)
: warning C4309: 'initializing' : truncation of constant value
ninja: build stopped: subcommand failed.

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:140: if
(response.client_auth_certificate().find(std::string(
For readability, consider declaring a separate const std::string& audioPolicy. 
Don't feel strongly though.

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:141: kAudioOnlyPolicy,
(arraysize(kAudioOnlyPolicy) /
Extra ()

[Kevin M, 2015-01-30 00:11:10]

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_auth_util.cc (right):

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:23: const char
kAudioOnlyPolicy[] =
On 2015/01/29 19:43:08, mark a. foltz wrote:
> This has to remain unsigned right?  It breaks compilation on Windows.
> 
> FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
> /showIncludes /FC
>
@obj\extensions\browser\api\cast_channel\extensions_browser.cast_auth_util.obj.rsp
> /c ..\..\extensions\browser\api\cast_channel\cast_auth_util.cc
>
/Foobj\extensions\browser\api\cast_channel\extensions_browser.cast_auth_util.obj
> /Fdobj\extensions\extensions_browser.cc.pdb 
>
e:\b\build\slave\win\build\src\extensions\browser\api\cast_channel\cast_auth_util.cc(24)
> : error C2220: warning treated as error - no 'object' file generated
>
e:\b\build\slave\win\build\src\extensions\browser\api\cast_channel\cast_auth_util.cc(24)
> : warning C4309: 'initializing' : truncation of constant value
> ninja: build stopped: subcommand failed.

Done.

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:140: if
(response.client_auth_certificate().find(std::string(
On 2015/01/29 19:43:08, mark a. foltz wrote:
> For readability, consider declaring a separate const std::string& audioPolicy.

> Don't feel strongly though.

Done.

https://codereview.chromium.org/890683002/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_auth_util.cc:141: kAudioOnlyPolicy,
(arraysize(kAudioOnlyPolicy) /
On 2015/01/29 19:43:08, mark a. foltz wrote:
> Extra ()

Done.

[vadimgo, 2015-01-30 00:17:49]

Thank you for fixing this, Kevin!

lgtm

[mark a. foltz, 2015-01-30 00:22:42]

lgtm with one nit

https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
File extensions/browser/api/cast_channel/cast_auth_util.cc (right):

https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
extensions/browser/api/cast_channel/cast_auth_util.cc:140: std::string
audio_policy =
const std::string&

[Kevin M, 2015-01-30 22:15:47]

https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
File extensions/browser/api/cast_channel/cast_auth_util.cc (right):

https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
extensions/browser/api/cast_channel/cast_auth_util.cc:140: std::string
audio_policy =
On 2015/01/30 00:22:42, mark a. foltz wrote:
> const std::string& 

I didn't know this was legal. Cool.

[Kevin M, 2015-01-30 22:17:00]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2015-01-30 22:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890683002/40001

[commit-bot: I haz the power, 2015-01-30 23:05:57]

Committed patchset #3 (id:40001)

[mark a. foltz, 2015-01-30 23:07:07]

On 2015/01/30 22:15:47, Kevin M wrote:
>
https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
> File extensions/browser/api/cast_channel/cast_auth_util.cc (right):
> 
>
https://codereview.chromium.org/890683002/diff/20001/extensions/browser/api/c...
> extensions/browser/api/cast_channel/cast_auth_util.cc:140: std::string
> audio_policy =
> On 2015/01/30 00:22:42, mark a. foltz wrote:
> > const std::string& 
> 
> I didn't know this was legal. Cool.

It's part of C++11 that has been supported by compilers for some time it looks
like.

http://herbsutter.com/2008/01/01/gotw-88-a-candidate-for-the-most-important-c...

[commit-bot: I haz the power, 2015-01-30 23:07:56]

Patchset 3 (id:??) landed as
https://crrev.com/e6b0fbf6516ff2731f4f55f1bbbc1e920d6f124a
Cr-Commit-Position: refs/heads/master@{#314019}