Use chrome.networkingPrivate in chrome://network

Use chrome.networkingPrivate in chrome://network

This CL:
* Enables chrome.networkingPrivate in chrome://network
* Replaces networkConfig with direct calls to chrome.networkingPrivate
* Moves the getShillProperties implementation (which is not available in networkingPrivate) into the network_ui.js and network_ui.cc files

BUG=453895
For webui resources:
TBR=xiyuan@chromium.org

Committed: https://crrev.com/e2697a79da9e5cde038c6fcb58a5e414c57c306a
Cr-Commit-Position: refs/heads/master@{#315093}

[stevenjb, 2015-01-29 23:42:44]

stevenjb@chromium.org changed reviewers:
+ kalman@chromium.org, reillyg@chromium.org

[stevenjb, 2015-01-29 23:42:45]

Hi guys, I am finally getting around to needing to use chrome extension APIs in
WebUI.

I am starting simple with chrome://network

Unfortunately this doesn't 'just work', something appears to be missing.

Any thoughts?

[stevenjb, 2015-01-29 23:51:12]

On 2015/01/29 23:42:45, stevenjb wrote:
> Hi guys, I am finally getting around to needing to use chrome extension APIs
in
> WebUI.
> 
> I am starting simple with chrome://network
> 
> Unfortunately this doesn't 'just work', something appears to be missing.
> 
> Any thoughts?

The specific error by the way is that 'chrome.networkingPrivate' is undefined.

[not at google - send to devlin, 2015-01-29 23:53:17]

https://codereview.chromium.org/890663003/diff/1/extensions/common/api/_api_f...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/890663003/diff/1/extensions/common/api/_api_f...
extensions/common/api/_api_features.json:206: "dependencies":
["permission:networkingPrivate"],
oh, this is a problem here. You can't depend on the networkingPrivate
permission, you need 2 separate rules, like

"netoworkingPrivate": [
  { /* current rule */ },
  { "contexts": ["webui"], ...}
]

[stevenjb, 2015-01-29 23:58:37]

Like this? Same error.

[not at google - send to devlin, 2015-01-30 00:03:49]

yes like that. hrm.

[stevenjb, 2015-01-30 01:02:32]

Aha! Finally saw an ERROR getting lost in the sea of chrome spam: 

base_feature_provider.cc(37)] networkingPrivate: Must supply a value for channel
or dependencies.

Fixed! I'll clean up the UI changes and ping you for a review shortly.

[stevenjb, 2015-01-30 19:22:21]

stevenjb@chromium.org changed reviewers:
+ pneubeck@chromium.org

[stevenjb, 2015-01-30 19:37:47]

OK, this is ready for review, PTAL.

[stevenjb, 2015-02-05 23:42:23]

ping

[not at google - send to devlin, 2015-02-06 00:28:39]

Extension stuff lgtm. Can't speak for networking obvs.

[pneubeck (no reviews), 2015-02-06 08:55:20]

great work, again less complexity.
lgtm

https://codereview.chromium.org/890663003/diff/80001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/network_ui.cc (right):

https://codereview.chromium.org/890663003/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/network_ui.cc:119:
scoped_ptr<base::DictionaryValue> unused_error_data) const {
nit: unused_error_data -> /* error_data */

[stevenjb, 2015-02-06 18:08:19]

New patchsets have been uploaded after l-g-t-m from
kalman@chromium.org,pneubeck@chromium.org

[stevenjb, 2015-02-06 18:22:08]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:22:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890663003/100001

[commit-bot: I haz the power, 2015-02-06 18:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:29:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[stevenjb, 2015-02-06 18:34:04]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:34:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890663003/100001

[commit-bot: I haz the power, 2015-02-06 20:06:35]

Committed patchset #6 (id:100001)

[stevenjb, 2015-02-06 20:07:03]

stevenjb@chromium.org changed reviewers:
+ jlklein@chromium.org

[stevenjb, 2015-02-06 20:07:03]

+jlklein@ FYI

[commit-bot: I haz the power, 2015-02-06 20:07:26]

Patchset 6 (id:??) landed as
https://crrev.com/e2697a79da9e5cde038c6fcb58a5e414c57c306a
Cr-Commit-Position: refs/heads/master@{#315093}