Report AudioParameters::Format in media-internals. Fix effects.

content/browser/media/media_internals.cc

Index: content/browser/media/media_internals.cc
diff --git a/content/browser/media/media_internals.cc b/content/browser/media/media_internals.cc
index e2a5ede68bbdd7fe2d38ccf0cdecd0dde7f32392..0e666ac3a2076320ce9b89b1f8a9f1ef70287c8f 100644
--- a/content/browser/media/media_internals.cc
+++ b/content/browser/media/media_internals.cc
@@ -42,6 +42,7 @@ std::string EffectsToString(int effects) {
     { media::AudioParameters::ECHO_CANCELLER, "ECHO_CANCELLER" },
     { media::AudioParameters::DUCKING, "DUCKING" },
     { media::AudioParameters::KEYBOARD_MIC, "KEYBOARD_MIC" },
+    { media::AudioParameters::HOTWORD, "HOTWORD" },
   };
 
   std::string ret;
@@ -63,6 +64,21 @@ std::string EffectsToString(int effects) {
   return ret;
 }
 
+std::string FormatToString(media::AudioParameters::Format format) {
+  switch (format) {
+    case media::AudioParameters::AUDIO_PCM_LINEAR:
+      return "pcm_linear";
+    case media::AudioParameters::AUDIO_PCM_LOW_LATENCY:
+      return "pcm_low_latency";
+    case media::AudioParameters::AUDIO_FAKE:
+      return "fake";
+    default:
+      break;

[watk, 2015/02/05 20:48:44]

Maybe you could remove the default case so we get a compiler warning if we add a
Format but forget to add a case here?

[DaleCurtis, 2015/02/05 21:14:54]

Good idea. Added a NOTREACHED() too.

+  }
+
+  return "unknown";
+}
+
 const char kAudioLogStatusKey[] = "status";
 const char kAudioLogUpdateFunction[] = "media.updateAudioComponent";
 
@@ -117,6 +133,7 @@ void AudioLogImpl::OnCreated(int component_id,
 
   dict.SetString(kAudioLogStatusKey, "created");
   dict.SetString("device_id", device_id);
+  dict.SetString("device_type", FormatToString(params.format()));
   dict.SetInteger("frames_per_buffer", params.frames_per_buffer());
   dict.SetInteger("sample_rate", params.sample_rate());
   dict.SetInteger("channels", params.channels());