Report AudioParameters::Format in media-internals. Fix effects.

Report AudioParameters::Format in media-internals. Fix effects.

This allows clients to tell when fallback to fake device has
occurred, which prevents silent no-audio failure situations.

The new key, "device_type" can be seen on all controllers and
streams created.

BUG=455371
TEST=chrome://media-internals

Committed: https://crrev.com/b9a6b787722a83745c25bc27d2d5b6f948b0d523
Cr-Commit-Position: refs/heads/master@{#315123}

[DaleCurtis, 2015-02-05 19:37:47]

dalecurtis@chromium.org changed reviewers:
+ watk@chromium.org, wolenetz@chromium.org

[DaleCurtis, 2015-02-05 19:38:03]

dalecurtis@chromium.org changed reviewers:
+ dgreid@chromium.org
- wolenetz@chromium.org

[watk, 2015-02-05 20:48:44]

lgtm, but my lgtm is powerless :(

https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
File content/browser/media/media_internals.cc (right):

https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
content/browser/media/media_internals.cc:76: break;
Maybe you could remove the default case so we get a compiler warning if we add a
Format but forget to add a case here?

[watk, 2015-02-05 20:49:11]

On 2015/02/05 20:48:44, watk wrote:
> lgtm, but my lgtm is powerless :(
> 
>
https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
> File content/browser/media/media_internals.cc (right):
> 
>
https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
> content/browser/media/media_internals.cc:76: break;
> Maybe you could remove the default case so we get a compiler warning if we add
a
> Format but forget to add a case here?

Or maybe it isn't..

[DaleCurtis, 2015-02-05 21:14:54]

https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
File content/browser/media/media_internals.cc (right):

https://codereview.chromium.org/890573003/diff/1/content/browser/media/media_...
content/browser/media/media_internals.cc:76: break;
On 2015/02/05 20:48:44, watk wrote:
> Maybe you could remove the default case so we get a compiler warning if we add
a
> Format but forget to add a case here?

Good idea. Added a NOTREACHED() too.

[DaleCurtis, 2015-02-05 21:17:46]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org

[DaleCurtis, 2015-02-05 21:17:47]

Actually I think Dylan's is powerless too, so +sandersd.

[DaleCurtis, 2015-02-05 22:03:26]

New patchsets have been uploaded after l-g-t-m from watk@chromium.org

[DaleCurtis, 2015-02-06 20:00:46]

Dan: Ping?

[sandersd (OOO until July 31), 2015-02-06 20:39:42]

lgtm

[DaleCurtis, 2015-02-06 20:43:33]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2015-02-06 20:44:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890573003/20001

[commit-bot: I haz the power, 2015-02-06 22:42:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 22:42:49]

Patchset 2 (id:??) landed as
https://crrev.com/b9a6b787722a83745c25bc27d2d5b6f948b0d523
Cr-Commit-Position: refs/heads/master@{#315123}