[turbofan] Fix OSR compilations of for-in.

[turbofan] Fix OSR compilations of for-in.

R=mstarzinger@chromium.org
LOG=Y
BUG=

Committed: https://crrev.com/11311c083abb37762ea979a25bf1f21c11928b20
Cr-Commit-Position: refs/heads/master@{#26333}

[Michael Starzinger, 2015-01-29 15:08:10]

LGTM with comments.

https://codereview.chromium.org/890543002/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler.cc#newcode1597
src/compiler.cc:1597: void CompilationInfo::PrintFunctionSourceForTesting() {
nit: Since this actually prints the desugared AST instead of the original
source, could we name this method PrintASTForTesting() instead?

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
src/compiler/ast-graph-builder.cc:717: void
AstGraphBuilder::BuildForInBody(ForInStatement* stmt) {
nit: Same TODO as in line 646 applies to this function, let's add a TODO here as
well.

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
src/compiler/ast-graph-builder.h:202: void BuildForInBody(ForInStatement* stmt);
Please call this s/Build/Visit/ here, there is a clear distinction between the
"Visit" and the "Build" family as explained in line 67 above.

[titzer, 2015-01-29 16:51:11]

https://codereview.chromium.org/890543002/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler.cc#newcode1597
src/compiler.cc:1597: void CompilationInfo::PrintFunctionSourceForTesting() {
On 2015/01/29 15:08:10, Michael Starzinger wrote:
> nit: Since this actually prints the desugared AST instead of the original
> source, could we name this method PrintASTForTesting() instead?

Done.

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
src/compiler/ast-graph-builder.cc:717: void
AstGraphBuilder::BuildForInBody(ForInStatement* stmt) {
On 2015/01/29 15:08:10, Michael Starzinger wrote:
> nit: Same TODO as in line 646 applies to this function, let's add a TODO here
as
> well.

Done.

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/890543002/diff/20001/src/compiler/ast-graph-b...
src/compiler/ast-graph-builder.h:202: void BuildForInBody(ForInStatement* stmt);
On 2015/01/29 15:08:10, Michael Starzinger wrote:
> Please call this s/Build/Visit/ here, there is a clear distinction between the
> "Visit" and the "Build" family as explained in line 67 above.

Done.

[titzer, 2015-01-29 16:53:14]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-01-29 16:53:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890543002/40001

[commit-bot: I haz the power, 2015-01-29 17:40:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-29 17:40:33]

Patchset 3 (id:??) landed as
https://crrev.com/11311c083abb37762ea979a25bf1f21c11928b20
Cr-Commit-Position: refs/heads/master@{#26333}