Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 890523002: Upgrade Blink to milliseconds-based last modified filetimes, part 6. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@sof-fileinfo-modtime-in-ms-4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upgrade Blink to milliseconds-based last modified filetimes, part 6. Have content::FileInfoToWebFileInfo() no longer fill in WebFileInfo::modificationTimeMS; it is now unused by Blink. Once landed, this lets Blink remove the WebFileInfo field entirely. This is part 6 in the following patch series, 1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ] 2: [chromium] fill in modificationTimeMS [ https://codereview.chromium.org/884413002/ ] 3: [blink] make use of modificationTimeMS [ https://codereview.chromium.org/884393002/ ] 4: [chromium] set modificationTime to something msec-based [ https://codereview.chromium.org/862203003/ ] 5: [blink] switch to modificationTime [ https://codereview.chromium.org/882343002/ ] 6: [chromium] *this one* [ https://codereview.chromium.org/890523002/ ] 7: [blink] remove modificationTimeMS [ https://codereview.chromium.org/869613005/ ] R=jochen BUG=451747 Committed: https://crrev.com/65e08559dd9b0bc349868a0b954d58f3dc9cae48 Cr-Commit-Position: refs/heads/master@{#315545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M content/child/file_info_util.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Final one in content/
5 years, 10 months ago (2015-02-10 06:17:57 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-10 10:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890523002/1
5 years, 10 months ago (2015-02-10 11:55:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 12:44:42 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 12:45:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65e08559dd9b0bc349868a0b954d58f3dc9cae48
Cr-Commit-Position: refs/heads/master@{#315545}

Powered by Google App Engine
This is Rietveld 408576698