Dartest CL - Please review

client/testing/unittest/shared.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Description text of the current test group. If multiple groups are nested,
  * this will contain all of their text concatenated.
  */
 String _currentGroup = '';
 
 /** Tests executed in this suite. */
 List<TestCase> _tests;
 
+/** Test Runner Function */

[Bob Nystrom, 2011/12/14 00:15:30]

This comment doesn't really add any value. How about "Callback used to run
tests. Entrypoints can replace this with their own if they want."

[shauvik, 2011/12/16 07:19:27]

Done.

+Function _testRunner;

[Bob Nystrom, 2011/12/14 00:15:30]

Rename "_runTests".

[shauvik, 2011/12/16 07:19:27]

There is already a function called "_runTests". Can't have two members with the
same name. Leaving this as it is.

On 2011/12/14 00:15:30, Bob Nystrom wrote:

+
 /** Whether this is run within dartium layout tests. */
 bool _isLayoutTest = false;
 
 /** Current test being executed. */
 int _currentTest = 0;
 
 /** Total number of callbacks that have been executed in the current test. */
 int _callbacksCalled = 0;
 
 final _UNINITIALIZED = 0;
@@ skipping 107 matching lines @@
   } else if (_callbacksCalled > testCase.callbacks) {
     final expected = testCase.callbacks;
     testCase.error(
         'More calls to callbackDone() than expected. '
         + 'Actual: ${_callbacksCalled}, expected: ${expected}', '');
     _state = _UNCAUGHT_ERROR;
   } else if ((_callbacksCalled == testCase.callbacks) &&
       (_state != _RUNNING_TEST)) {
     testCase.pass();
     _currentTest++;
-    _nextBatch();
+    _testRunner();
   }
 }
 
 void forLayoutTests() {
   _isLayoutTest = true;
 }
 
 /** Runs all queued tests, one at a time. */
 _runTests() {
   _platformStartTests();
 
   _platformDefer(() {
     assert (_currentTest == 0);
-    _nextBatch();
+    _testRunner();
   });
 }
 
 /** Runs a single test. */
 _runTest(TestCase testCase) {
   try {
     _callbacksCalled = 0;
     _state = _RUNNING_TEST;
 
     testCase.test();
@@ skipping 64 matching lines @@
 
 /**
  * Lazily initializes the test library if not already initialized.
  */
 _ensureInitialized() {
   if (_state != _UNINITIALIZED) return;
 
   _tests = <TestCase>[];
   _currentGroup = '';
   _state = _READY;
+  
+  //Set _nextBatch() as default test runner

[Bob Nystrom, 2011/12/14 00:15:30]

Obvious comment is obvious. Remove it. :)

[shauvik, 2011/12/16 07:19:27]

Done.

+  _testRunner = _nextBatch;
+  
 
   _platformInitialize();
 
   // Immediately queue the suite up. It will run after a timeout (i.e. after
   // main() has returned).
   _platformDefer(_runTests);
 }
 
 /**
  * Wraps an value and provides an "==" operator that can be used to verify that
@@ skipping 70 matching lines @@
   /** Error or failure message. */
   String message  = '';
 
   /**
    * One of [_PASS], [_FAIL], or [_ERROR] or [null] if the test hasn't run yet.
    */
   String result;
 
   /** Stack trace associated with this test, or null if it succeeded. */
   String stackTrace;
+  
+  Date startDate;

[Bob Nystrom, 2011/12/14 00:15:30]

Rename "startTime".

[shauvik, 2011/12/16 07:19:27]

Done.

+  
+  Duration timeDuration;

[Bob Nystrom, 2011/12/14 00:15:30]

Rename "runningTime".

[shauvik, 2011/12/16 07:19:27]

Done.

 
   TestCase(this.id, this.description, this.test, this.callbacks);
 
+  set startingDate(Date startDate) => this.startDate = startDate;

[Bob Nystrom, 2011/12/14 00:15:30]

Remove this.

[shauvik, 2011/12/16 07:19:27]

Done.

+
+  set runningTime(Duration timeDuration) => this.timeDuration = timeDuration;

[Bob Nystrom, 2011/12/14 00:15:30]

And this.

[shauvik, 2011/12/16 07:19:27]

Done.

+  
   bool get isComplete() => result != null;
 
   void pass() {
     result = _PASS;
   }
 
   void fail(String message, String stackTrace) {
     result = _FAIL;
     this.message = message;
     this.stackTrace = stackTrace;
   }
 
   void error(String message, String stackTrace) {
     result = _ERROR;
     this.message = message;
     this.stackTrace = stackTrace;
   }
 }
 
 typedef void TestFunction();