Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 8905009: Add syntax coloring support for raw strings and string interpolation (Closed)

Created:
9 years ago by Brian Wilkerson
Modified:
9 years ago
Reviewers:
messick, pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add syntax coloring support for raw strings and string interpolation Committed: https://code.google.com/p/dart/source/detail?r=2350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -439 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/BufferedDocumentScanner.java View 4 chunks +42 lines, -21 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/FastDartPartitionScanner.java View 6 chunks +288 lines, -394 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/DartPartitions.java View 2 chunks +9 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/TestAll.java View 2 chunks +10 lines, -13 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/TestAll.java View 1 chunk +25 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/TestAll.java View 1 chunk +25 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/functions/FastDartPartitionScannerTest.java View 1 chunk +172 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/functions/TestAll.java View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
9 years ago (2011-12-12 16:40:33 UTC) #1
messick
9 years ago (2011-12-12 17:19:22 UTC) #2
LGTM!

I thought this was going to require some rewriting; thanks for doing it.

Powered by Google App Engine
This is Rietveld 408576698