Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 890493002: Allow getrusage under ASAN. (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow getrusage under ASAN. BUG=413528 Committed: https://crrev.com/ff97bf241072f6dbce00e49c215462ae0c0b7c24 Cr-Commit-Position: refs/heads/master@{#313674}

Patch Set 1 #

Patch Set 2 : Restrict who to RUSAGE_SELF. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rickyz (no longer on Chrome)
5 years, 10 months ago (2015-01-29 04:05:44 UTC) #2
jln (very slow on Chromium)
lgtm if we know that ASAN will use it. Could you restrict |who| to RUSAGE_SELF ...
5 years, 10 months ago (2015-01-29 05:46:34 UTC) #3
rickyz (no longer on Chrome)
On 2015/01/29 05:46:34, jln wrote: > lgtm if we know that ASAN will use it. ...
5 years, 10 months ago (2015-01-29 06:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890493002/20001
5 years, 10 months ago (2015-01-29 06:11:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 07:01:12 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 07:02:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff97bf241072f6dbce00e49c215462ae0c0b7c24
Cr-Commit-Position: refs/heads/master@{#313674}

Powered by Google App Engine
This is Rietveld 408576698