Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/public/common/referrer.cc

Issue 890473003: Add missig referrer policies to sanitization code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/referrer.cc
diff --git a/content/public/common/referrer.cc b/content/public/common/referrer.cc
index b383fb73fc6fae4f4b820140c92bcca2e60adbf8..225df96c94dbeb8b523c29fcd9e618d772edd2f1 100644
--- a/content/public/common/referrer.cc
+++ b/content/public/common/referrer.cc
@@ -22,6 +22,12 @@ Referrer Referrer::SanitizeForRequest(const GURL& request,
bool is_downgrade =
sanitized_referrer.url.SchemeIsSecure() && !request.SchemeIsSecure();
+ if (sanitized_referrer.policy < 0 ||
+ sanitized_referrer.policy > blink::WebReferrerPolicyLast) {
+ NOTREACHED();
+ sanitized_referrer.policy = blink::WebReferrerPolicyNever;
+ }
+
switch (sanitized_referrer.policy) {
case blink::WebReferrerPolicyDefault:
if (is_downgrade) {
@@ -44,8 +50,9 @@ Referrer Referrer::SanitizeForRequest(const GURL& request,
case blink::WebReferrerPolicyOrigin:
sanitized_referrer.url = sanitized_referrer.url.GetOrigin();
break;
- default:
- NOTREACHED();
+ case blink::WebReferrerPolicyOriginWhenCrossOrigin:
+ if (request.GetOrigin() != sanitized_referrer.url.GetOrigin())
+ sanitized_referrer.url = sanitized_referrer.url.GetOrigin();
break;
}
return sanitized_referrer;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698