chrome/browser/ui/apps/chrome_app_window_client.cc - Issue 890463003: [DevTools] Fix crash in DevToolsWindow::Create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_app_window_client.cc

Issue 890463003: [DevTools] Fix crash in DevToolsWindow::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/apps/chrome_app_window_client.cc

diff --git a/chrome/browser/ui/apps/chrome_app_window_client.cc b/chrome/browser/ui/apps/chrome_app_window_client.cc

index fc9eb507add7461f04b238e2c1edbb77b3c87c53..5ac75521e341ad95819a6c09b19b0e458dbdf28c 100644

--- a/chrome/browser/ui/apps/chrome_app_window_client.cc

+++ b/chrome/browser/ui/apps/chrome_app_window_client.cc

@@ -57,7 +57,11 @@ void ChromeAppWindowClient::OpenDevToolsWindow(

const base::Closure& callback) {

DevToolsWindow* devtools_window = DevToolsWindow::OpenDevToolsWindow(

web_contents, DevToolsToggleAction::ShowConsole());

- devtools_window->SetLoadCompletedCallback(callback);

+ if (devtools_window) {

+ devtools_window->SetLoadCompletedCallback(callback);

+ } else {

+ callback.Run();

+ }

}

bool ChromeAppWindowClient::IsCurrentChannelOlderThanDev() {