[DevTools] Fix crash in DevToolsWindow::Create

[DevTools] Fix crash in DevToolsWindow::Create

BUG=452950
Committed: https://crrev.com/0963ad79e213b65c6afdf611a353b93db47a0457
Cr-Commit-Position: refs/heads/master@{#314142}

[vkuzkokov, 2015-01-29 14:04:29]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-01-29 15:50:35]

Please specify a bug number.

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:451: if (window)
Let's only |if (window)| in this method, and |DCHECK(window)| in all other
places.

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:454:
window->ScheduleShow(DevToolsToggleAction::Show());
This |window| may be nullptr.

[pfeldman, 2015-01-29 16:09:58]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-01-29 16:09:59]

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:737: if (!window->bindings_) {
Why is this happening? It makes code so much more complex.

[vkuzkokov, 2015-01-30 12:44:15]

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:451: if (window)
On 2015/01/29 15:50:35, dgozman wrote:
> Let's only |if (window)| in this method, and |DCHECK(window)| in all other
> places.

Done.

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:454:
window->ScheduleShow(DevToolsToggleAction::Show());
On 2015/01/29 15:50:35, dgozman wrote:
> This |window| may be nullptr.

Done.

https://codereview.chromium.org/890463003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:737: if (!window->bindings_) {
On 2015/01/29 16:09:59, pfeldman wrote:
> Why is this happening? It makes code so much more complex.

DevToolsUI might be not created for some reason. Bad frontend_url from
remote device would do the trick.

[dgozman, 2015-01-30 13:02:08]

lgtm

https://codereview.chromium.org/890463003/diff/20001/chrome/browser/devtools/...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/890463003/diff/20001/chrome/browser/devtools/...
chrome/browser/devtools/devtools_window.cc:451: if (window)
I'd just |if (!window) return;|.

[vkuzkokov, 2015-02-02 13:28:18]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2015-02-02 13:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890463003/20001

[commit-bot: I haz the power, 2015-02-02 14:16:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-02 14:17:22]

Patchset 2 (id:??) landed as
https://crrev.com/0963ad79e213b65c6afdf611a353b93db47a0457
Cr-Commit-Position: refs/heads/master@{#314142}