Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 890443002: Roll BoringSSL 347f025..a87de9b. (Closed)

Created:
5 years, 10 months ago by eroman
Modified:
5 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll BoringSSL 347f025..a87de9b. Changes: a87de9b Define WIN32_LEAN_AND_MEAN in the build system, not in the code. 4a0f0c4 Change CMakeLists.txt to two-space indent. 2e38008 Define _HAS_EXCEPTIONS=0 to avoid MSVC C4530 warning. bcc4fa8 Add unit-tests for PBKDF2. 507c1ee Honor the standard BUILD_SHARED_LIBS cmake variable. f4600ad Add missing OPENSSL_EXPORTs. f058dae Revert "Add a test for CONF_parse_list." dc94b54 Clean up use of Windows Platform SDK headers. 33970e6 Enable bssl client/s_client and server/s_server on Windows. 9a9a193 Build with -fvisibility=hidden. afdaeee Enable bssl (md5sum, sha256sum, etc.) on Windows. 2fe7f2d Initialize HMAC keys to zero. 1d75c8b Improve compatibility with CMake 3.0 and later ed30c0d Improve the documentation in BUILDING b7f3144 Add a style guide. 69ad27f Run x86 perlasm on UNIX with -fPIC. 36eb7d5 Fix buffer size in aead_test.c. 53cbd6c Fix unused variable warning in OPENSSL_NO_ASM build. bed8f73 Fix build after mistake addressing comments in cca4d599. cca4d59 Add digest sum handling to the tool. cd5c892 Add a test for CONF_parse_list. fd4eb60 Remove duplication of common DH parameters. b4a494c Reformat SSL/TLS headers. For more details see: https://boringssl.googlesource.com/boringssl/+log/347f025..a87de9b Committed: https://crrev.com/e447037a8fa2541473e34677eb65a81455c270a9 Cr-Commit-Position: refs/heads/master@{#313784}

Patch Set 1 #

Patch Set 2 : Add in a87de9b to fix windows compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
eroman
5 years, 10 months ago (2015-01-29 02:05:20 UTC) #2
eroman
Looks like there is a Windows compile problem: https://code.google.com/p/chromium/issues/detail?id=453196 Probably won't get around to that ...
5 years, 10 months ago (2015-01-29 02:27:51 UTC) #3
eroman
Updated to a87de9b, it should compile on Windows now. I don't believe any gyp/gn changes ...
5 years, 10 months ago (2015-01-29 20:08:12 UTC) #4
davidben
lgtm if it builds
5 years, 10 months ago (2015-01-29 20:09:56 UTC) #5
eroman
Confirmed -- The win8 trybot has already compiled the boringssl files: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3081/steps/compile/logs/stdio
5 years, 10 months ago (2015-01-29 20:12:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890443002/20001
5 years, 10 months ago (2015-01-29 20:14:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 20:56:21 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:57:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e447037a8fa2541473e34677eb65a81455c270a9
Cr-Commit-Position: refs/heads/master@{#313784}

Powered by Google App Engine
This is Rietveld 408576698