Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890423004: Files.app: Add FileSystemMetadataModel. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add FileSystemMetadataModel. The model dispatches the requests depends on the entry's location. BUG=410766 TEST=FileManagerJsTest.FileSystemMetadataModel Committed: https://crrev.com/7602e721b8718fd828ee8286bfed941f17fc695d Cr-Commit-Position: refs/heads/master@{#314965}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 14 (7 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-05 10:34:33 UTC) #7
yawano
https://codereview.chromium.org/890423004/diff/80001/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js File ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js (right): https://codereview.chromium.org/890423004/diff/80001/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js#newcode58 ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js:58: volumeInfo.volumeType === VolumeManagerCommon.VolumeType.MTP || Is MTP volume supported by ...
5 years, 10 months ago (2015-02-05 11:02:06 UTC) #8
hirono
https://codereview.chromium.org/890423004/diff/80001/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js File ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js (right): https://codereview.chromium.org/890423004/diff/80001/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js#newcode58 ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js:58: volumeInfo.volumeType === VolumeManagerCommon.VolumeType.MTP || On 2015/02/05 11:02:06, yawano wrote: ...
5 years, 10 months ago (2015-02-05 11:30:49 UTC) #9
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-05 11:45:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890423004/120001
5 years, 10 months ago (2015-02-06 02:29:03 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:120001)
5 years, 10 months ago (2015-02-06 03:44:26 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:46:49 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7602e721b8718fd828ee8286bfed941f17fc695d
Cr-Commit-Position: refs/heads/master@{#314965}

Powered by Google App Engine
This is Rietveld 408576698