Issue 890393002: Deflaked fast/animation/last-child-assert.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890393002: Deflaked fast/animation/last-child-assert.html (Closed)

Created:
5 years, 10 months ago by rune

Modified:
5 years, 10 months ago

Reviewers:
mstensho (USE GERRIT)

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Deflaked fast/animation/last-child-assert.html The source of the flake was that the resulting background-color was not always white during the transition. I was able to turn it into a text based test and confirmed that the test still triggers the assert with the initial fix reverted. R=mstensho@opera.com BUG=453899 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189336

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	LayoutTests/FlakyTests	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/animation/last-child-assert.html	View	1 chunk	+7 lines, -3 lines	0 comments	Download
D	LayoutTests/fast/animation/last-child-assert-expected.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
A	LayoutTests/fast/animation/last-child-assert-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890393002/1

5 years, 10 months ago (2015-02-02 12:26:34 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-02 14:04:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189336

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages