TestBlinkWebUnitTestSupport to create the scheduler on the main thread

TestBlinkWebUnitTestSupport to create the scheduler on the main thread

Rather than lazily creatng the schedueler (which could happen on any
thread), create it in the constructor if there is a message loop.
Frustratingly the problem this solves only shows up if you
run all the webkit_tests, not just one of them.

BUG=391005
Committed: https://crrev.com/37b558ceb861b950dd6e598f9b6f56291448b5fb
Cr-Commit-Position: refs/heads/master@{#314309}

[alex clarke (OOO till 29th), 2015-02-02 14:01:02]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2015-02-02 14:28:08]

Good catch, lgtm.

[Sami, 2015-02-02 14:28:33]

https://codereview.chromium.org/890333003/diff/1/content/test/test_blink_web_...
File content/test/test_blink_web_unit_test_support.cc (right):

https://codereview.chromium.org/890333003/diff/1/content/test/test_blink_web_...
content/test/test_blink_web_unit_test_support.cc:67: if
(base::MessageLoopProxy::current()) {
Is this ever going to be false?

[alex clarke (OOO till 29th), 2015-02-02 14:30:06]

https://codereview.chromium.org/890333003/diff/1/content/test/test_blink_web_...
File content/test/test_blink_web_unit_test_support.cc (right):

https://codereview.chromium.org/890333003/diff/1/content/test/test_blink_web_...
content/test/test_blink_web_unit_test_support.cc:67: if
(base::MessageLoopProxy::current()) {
On 2015/02/02 14:28:33, Sami wrote:
> Is this ever going to be false?

Yes. The UnitTestTestSuite uses this but (unlike blink::TestEnvironment) it
doesn't create a message loop.

[alex clarke (OOO till 29th), 2015-02-02 14:31:49]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org

[alex clarke (OOO till 29th), 2015-02-02 14:31:49]

jochen@chromium.org: Please take a look!

[alex clarke (OOO till 29th), 2015-02-02 17:09:08]

alexclarke@chromium.org changed reviewers:
+ sievers@google.com

[alex clarke (OOO till 29th), 2015-02-02 17:09:30]

+sievers Can you please take a look?

[alex clarke (OOO till 29th), 2015-02-02 17:53:53]

alexclarke@chromium.org changed reviewers:
+ sievers@chromium.org
- sievers@google.com

[no sievers, 2015-02-02 18:52:54]

On 2015/02/02 17:09:30, alexclarke1 wrote:
> +sievers Can you please take a look?

lgtm

[alex clarke (OOO till 29th), 2015-02-03 10:18:26]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-02-03 10:19:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890333003/1

[commit-bot: I haz the power, 2015-02-03 11:07:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-03 11:08:06]

Patchset 1 (id:??) landed as
https://crrev.com/37b558ceb861b950dd6e598f9b6f56291448b5fb
Cr-Commit-Position: refs/heads/master@{#314309}