Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 890313002: Change ImageLoaderClient to return width and height of image. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ImageLoaderClient to return width and height of image. ListThumbnailLoader(http://crrev.com/885323002) directly returns dataUrl, width and height of thumbnail image instead of attaching it to image element. We want to directly obtain dataUrl, width and height of thumbnail from ImageLoaderClient. BUG=438050 TEST=Manually tested. Committed: https://crrev.com/d708495698cccaf3e1ced6bbbb7f90222e807f86 Cr-Commit-Position: refs/heads/master@{#314120}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Patch Set 3 : Fix test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M ui/file_manager/image_loader/cache.js View 5 chunks +9 lines, -4 lines 0 comments Download
M ui/file_manager/image_loader/image_loader_client.js View 1 4 chunks +13 lines, -5 lines 0 comments Download
M ui/file_manager/image_loader/image_loader_client_unittest.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/request.js View 6 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-02 06:11:08 UTC) #2
hirono
lgtm with a nit. Thanks! https://codereview.chromium.org/890313002/diff/1/ui/file_manager/image_loader/image_loader_client.js File ui/file_manager/image_loader/image_loader_client.js (right): https://codereview.chromium.org/890313002/diff/1/ui/file_manager/image_loader/image_loader_client.js#newcode121 ui/file_manager/image_loader/image_loader_client.js:121: * @param {function(Object)} callback ...
5 years, 10 months ago (2015-02-02 06:56:01 UTC) #3
yawano
Thank you for the review! https://codereview.chromium.org/890313002/diff/1/ui/file_manager/image_loader/image_loader_client.js File ui/file_manager/image_loader/image_loader_client.js (right): https://codereview.chromium.org/890313002/diff/1/ui/file_manager/image_loader/image_loader_client.js#newcode121 ui/file_manager/image_loader/image_loader_client.js:121: * @param {function(Object)} callback ...
5 years, 10 months ago (2015-02-02 07:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890313002/20001
5 years, 10 months ago (2015-02-02 07:35:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/20428)
5 years, 10 months ago (2015-02-02 08:36:55 UTC) #8
yawano
The previous patch set broke a test case. I fixed it with a new patch ...
5 years, 10 months ago (2015-02-02 08:48:57 UTC) #9
hirono
still lgtm!
5 years, 10 months ago (2015-02-02 08:50:47 UTC) #10
yawano
On 2015/02/02 08:50:47, hirono wrote: > still lgtm! Thank you!
5 years, 10 months ago (2015-02-02 08:51:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890313002/40001
5 years, 10 months ago (2015-02-02 08:52:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-02 09:31:22 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 09:32:28 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d708495698cccaf3e1ced6bbbb7f90222e807f86
Cr-Commit-Position: refs/heads/master@{#314120}

Powered by Google App Engine
This is Rietveld 408576698