Fixing crash upon window manager creation

Fixing crash upon window manager creation

BUG=452608
TEST=existing unit tests

Committed: https://crrev.com/388e681bb3df5e658559615fc417473402c32242
Cr-Commit-Position: refs/heads/master@{#314276}

[Mr4D (OOO till 08-26), 2015-02-02 02:36:08]

skuhne@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Mr4D (OOO till 08-26), 2015-02-02 02:36:09]

Ignoring was not an option. Fixed. Please have a look!

[Nikita (slow), 2015-02-02 16:59:52]

lgtm

[Nikita (slow), 2015-02-02 16:59:59]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-02-02 17:00:00]

lgtm

[commit-bot: I haz the power, 2015-02-02 17:00:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890293002/1

[commit-bot: I haz the power, 2015-02-02 17:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-02 17:05:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mr4D (OOO till 08-26), 2015-02-03 00:36:46]

skuhne@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Mr4D (OOO till 08-26), 2015-02-03 00:36:46]

+Stevenjb for OWNERS review of
wallpaper_private_apu_unittest.cc and message_center_notification_unittest.cc

[Mr4D (OOO till 08-26), 2015-02-03 00:46:52]

skuhne@chromium.org changed reviewers:
+ mukai@chromium.org

[Mr4D (OOO till 08-26), 2015-02-03 00:46:53]

Since +mukai is around, I add him for the owners review. Thanks!

[Jun Mukai, 2015-02-03 00:49:46]

notification lgtm

[Mr4D (OOO till 08-26), 2015-02-03 01:01:49]

skuhne@chromium.org changed reviewers:
+ benwells@chromium.org

[Mr4D (OOO till 08-26), 2015-02-03 01:01:49]

+Benwells for owner review of wallpaper_private_apu_unittest.cc

[stevenjb, 2015-02-03 01:31:58]

If we need this urgently, lgtm as-is, we can consider my comments in a follow up
(or ignore them).

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:256:
user_id_to_app_observer_.end());
nit: This only actually ensures that we don't call AddUser more than once, which
will only be true if  multi_user_util::GetProfileFromUserID(current_user_id_)
returns a valid Profile below. We may want to test that first, or at least
clarify the comment a little.

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:261:
AddSessionStateObserver(this);
nit: {}

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
(right):

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h:245:
std::string current_user_id_;
This should be able to be const, which will help ensure that the test in Init()
is correct.

[Mr4D (OOO till 08-26), 2015-02-03 02:06:05]

Addressed. Thanks!

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:256:
user_id_to_app_observer_.end());
We add the observer as well - so it is not only the AddUser which gets called in
that special case. Generally speaking an Init function should not get called
several times. But I changed the comment slightly.

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:261:
AddSessionStateObserver(this);
On 2015/02/03 01:31:58, stevenjb wrote:
> nit: {}

Done.

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
(right):

https://codereview.chromium.org/890293002/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h:245:
std::string current_user_id_;
The current user can be changed (ActiveUserChanged(..)).

[Mr4D (OOO till 08-26), 2015-02-03 02:06:09]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2015-02-03 02:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890293002/20001

[commit-bot: I haz the power, 2015-02-03 04:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 04:07:50]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (None)

[Mr4D (OOO till 08-26), 2015-02-03 04:08:32]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2015-02-03 04:09:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890293002/20001

[commit-bot: I haz the power, 2015-02-03 05:45:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-03 05:46:24]

Patchset 2 (id:??) landed as
https://crrev.com/388e681bb3df5e658559615fc417473402c32242
Cr-Commit-Position: refs/heads/master@{#314276}