[rAC, OSX] Fix dialog jankiness.

[rAC, OSX] Fix dialog jankiness.

Ensure that subviews of the requestAutocomplete dialog are fully laid
out before anything is displayed on screen. This gets rid of visual
artifacts from partial rendering.

BUG=315982
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237505

[groby-ooo-7-16, 2013-11-26 21:53:47]

Nico, please take a look.

The previous code using performSelector executed the layout _after_
displayIfNeeded (because field values are already updated) and so led to
jankiness. This  change forces layout to occur right before display, akin to
10.7's layoutIfNeeded.

[Nico, 2013-11-27 01:03:05]

Neat! lgtm with _ on ivar

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
(right):

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm:29:
namespace {
const has implicit internal linkage, empty namespace not needed

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm:42: BOOL
needsLayout;  // Indicates that the subviews need to be laid out.
don't we name instance variables with a trailing _?

[groby-ooo-7-16, 2013-11-27 01:34:03]

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
(right):

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm:29:
namespace {
On 2013/11/27 01:03:06, Nico wrote:
> const has implicit internal linkage, empty namespace not needed

Done.

https://codereview.chromium.org/89023003/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm:42: BOOL
needsLayout;  // Indicates that the subviews need to be laid out.
On 2013/11/27 01:03:06, Nico wrote:
> don't we name instance variables with a trailing _?
Yes, we do. My brain is already eating turkey, it seems.
Done.

[commit-bot: I haz the power, 2013-11-27 01:35:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/89023003/20001

[commit-bot: I haz the power, 2013-11-27 04:10:26]

Change committed as 237505