Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/tools/crash_service/caps/caps.gyp

Issue 890213002: Add basic support for CAPS exe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/tools/crash_service/caps/caps.gyp
diff --git a/chrome/tools/crash_service/caps/caps.gyp b/chrome/tools/crash_service/caps/caps.gyp
index f18f84d6c4413d06a4429b0986a92883daa933fd..0452959338251621622efc8ef35eeb09ad0f5df4 100644
--- a/chrome/tools/crash_service/caps/caps.gyp
+++ b/chrome/tools/crash_service/caps/caps.gyp
@@ -39,14 +39,21 @@
'target_name': 'caps',
'type': 'executable',
'include_dirs': [
- '../..',
cpu_(ooo_6.6-7.5) 2015/02/01 19:08:41 I think I cargo cult this.
+ '..',
+ '<(DEPTH)/',
scottmg 2015/02/01 19:55:35 don't use DEPTH in gyp files. it's only meant for
cpu_(ooo_6.6-7.5) 2015/02/03 02:44:58 Done.
],
'sources': [
'main_win.cc',
+ 'logger_win.cc',
+ 'logger_win.h',
+ 'process_singleton_win.cc',
+ 'process_singleton_win.h',
'<(SHARED_INTERMEDIATE_DIR)/caps/caps_version.rc',
],
'dependencies': [
'caps_resources',
+ '<(DEPTH)/base/base.gyp:base',
scottmg 2015/02/01 19:55:35 same here, just ../../../base/base.gyp:base is pre
cpu_(ooo_6.6-7.5) 2015/02/03 02:44:58 Done.
+ '<(DEPTH)/chrome/chrome.gyp:common_version',
cpu_(ooo_6.6-7.5) 2015/02/01 19:08:41 that is how I force chrome/common/chrome_version_i
scottmg 2015/02/01 19:55:35 Acknowledged.
],
'msvs_settings': {
'VCLinkerTool': {
« no previous file with comments | « no previous file | chrome/tools/crash_service/caps/logger_win.h » ('j') | chrome/tools/crash_service/caps/logger_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698