Issue 890203002: Disable linking chrome.dll on GN Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890203002: Disable linking chrome.dll on GN Windows. (Closed)

Created:
5 years, 10 months ago by brettw

Modified:
5 years, 10 months ago

Reviewers:
dpranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Disable linking chrome.dll on GN Windows. TBR=dpranke Committed: https://crrev.com/18493ebe8d788acb9be1a03f2af791d9c3eebd38 Cr-Commit-Position: refs/heads/master@{#314081}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -67 lines)			Patch
	M	chrome/BUILD.gn	View		2 chunks	+71 lines, -67 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890203002/1

5 years, 10 months ago (2015-02-01 01:10:44 UTC) #3

commit-bot: I haz the power

5 years, 10 months ago (2015-02-01 03:18:05 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/18493ebe8d788acb9be1a03f2af791d9c3eebd38
Cr-Commit-Position: refs/heads/master@{#314081}